Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jatin get profile images from website #2714

Open
wants to merge 11 commits into
base: development
Choose a base branch
from

Conversation

JatinAgrawal94
Copy link
Contributor

@JatinAgrawal94 JatinAgrawal94 commented Sep 22, 2024

Description

Screenshot 2024-09-08 at 1 41 52 PM

Related PRS (if any):

This frontend PR is related to the #1116 backend PR.

Main changes explained:

  • Added confirmRemoveModal.js to components/UserProfileModal.
  • Added suggestedProfileModal.js to components/UserProfileModal.
  • Made Changes to UserProfileModal.css and UserProfile.jsx files.

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. log as any user
  5. go to UserProfile Page.
  6. If you have a profile on the onecommunity website, you should either have a profile image(if it was empty before) else you should see a suggested Profile Image button to display all the images that match your name.

Screenshots or videos of changes:

profile_images.mp4

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 51a21f0
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67898fe34971cf00080717dd
😎 Deploy Preview https://deploy-preview-2714--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Dk-21
Dk-21 previously requested changes Sep 26, 2024
Copy link
Contributor

@Dk-21 Dk-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR-2714
@JatinAgrawal94
I tested the changes in the code.
I Can't see any of My photo or Suggested Profile Image Button to Display the images that match my name.

Suggestion : Also, We have to manually Enter the name otherwise it leads to the blank page. The name retrieval can be optimized to automatic retrieval from the User profile.

Thank You
PR-2714(1)

@JatinAgrawal94
Copy link
Contributor Author

JatinAgrawal94 commented Sep 26, 2024

@JatinAgrawal94 I tested the changes in the code. I Can't see any of My photo or Suggested Profile Image Button to Display the images that match my name.

Thank You PR-2714(1)

Hello Denish,
Do you have your bio posted on https://www.onecommunityglobal.org/team ? If yes, Only then your profile image would be changed and you will be able to see suggested Images button. For testing purposes only , take my first and last name and check if the feature works for you.
If you have any other questions, Please let me know.

@Dk-21 Dk-21 dismissed their stale review October 2, 2024 22:11

Didn't understand the requirements in the code changes.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Oct 6, 2024
Copy link
Contributor

@Ankuriboh Ankuriboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I am not sure if the remove avatar feature is needed.

Copy link

@mrinalini-raghavendran19 mrinalini-raghavendran19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jatin,

I tried testing this PR, with the suggestion from one of your comments asking you to use your name for testing but it doesn't seem to work for me.

Are there any other things I need to look into before testing this PR?

Screenshot 2024-10-07 at 2 30 33 PM

Copy link

@Rui-Liu-github Rui-Liu-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I reviewed an PR #2714 @JatinAgrawal94 . I pulled the latest version to my local environment to check the fix. I'm not sure if others are experiencing the same issue, but the profile page couldn't be loaded, and errors were displayed in the browser.

Review_.2714.mov

Copy link

@Rui-Liu-github Rui-Liu-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the PR #2714 just now and try again, but still couldn't be loaded for the profile page.

image

@samarth9201
Copy link
Contributor

I reviewd the PR. When trying to change the profile image, it displays the message "Please click on "Save changes" to save the changes you have made.", however I cannot click the button.

Screenshot (111)

@@ -317,6 +337,7 @@ function UserProfile(props) {
try {
const response = await axios.get(ENDPOINTS.USER_PROFILE(userId));
const newUserProfile = response.data;
console.log(newUserProfile.profilePic)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove console.log()

<Button color="danger" onClick={toggleRemoveModal} className="remove-button">
Remove Image</Button>:<></>}
{((userProfile?.profilePic==undefined ||
userProfile?.profilePic==null ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of == use ===

@sheetalmangate
Copy link
Contributor

Code changes are looking good only having few suggestions.

  1. Remove console.log for printing profile image
  2. for comparison use === instead of ==

Could not test it locally.

sheetalmangate
sheetalmangate previously approved these changes Oct 26, 2024
Copy link
Contributor

@sheetalmangate sheetalmangate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the code only need below modification

  1. Removing console.log()

@humera314
Copy link

I attempted to navigate to the User Profile page but encountered an error that prevented access.

image image

Copy link

@ajitp4292 ajitp4292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User Profile page is not accessible.
Screenshot 2024-11-02 at 3 53 24 PM

@JatinAgrawal94
Copy link
Contributor Author

I reviewd the PR. When trying to change the profile image, it displays the message "Please click on "Save changes" to save the changes you have made.", however I cannot click the button.

Screenshot (111)

The save button is present at the bottom of the page.

@JatinAgrawal94
Copy link
Contributor Author

User Profile page is not accessible. Screenshot 2024-11-02 at 3 53 24 PM

Please clone the repository again and review. I have made significant changes to for that issue.

Copy link

@Rupa2400 Rupa2400 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed PR #2714 from @JatinAgrawal94 and pulled the latest version into my local environment to test the fix. However, when I tried loading the profile page, it wouldn't display, and I ran into errors in the browser. I'm not sure if anyone else is experiencing the same issue.

PR_2714

Copy link

@audreydieuanh audreydieuanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profile page isn't loading, and the console shows an error: TypeError: undefined is not an object (evaluating 'suggestedProfilePics.map'). I suspect this is happening in the file src/components/UserProfile/UserProfileModal/suggestedProfileModal.js, where the code attempts to use the .map() method on suggestedProfilePics, which is currently undefined.

test3

@JatinAgrawal94
Copy link
Contributor Author

The profile page isn't loading, and the console shows an error: TypeError: undefined is not an object (evaluating 'suggestedProfilePics.map'). I suspect this is happening in the file src/components/UserProfile/UserProfileModal/suggestedProfileModal.js, where the code attempts to use the .map() method on suggestedProfilePics, which is currently undefined.

test3 test3

Can you please upload the complete video for reference , starting from making required changes to the code.

@audreydieuanh
Copy link

The profile page isn't loading, and the console shows an error: TypeError: undefined is not an object (evaluating 'suggestedProfilePics.map'). I suspect this is happening in the file src/components/UserProfile/UserProfileModal/suggestedProfileModal.js, where the code attempts to use the .map() method on suggestedProfilePics, which is currently undefined.
test3

    [
      
        ![test3](https://private-user-images.githubusercontent.com/127930337/382514988-66cbc743-037c-4726-861b-b8421d6fea52.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA1OTM0NzEsIm5iZiI6MTczMDU5MzE3MSwicGF0aCI6Ii8xMjc5MzAzMzcvMzgyNTE0OTg4LTY2Y2JjNzQzLTAzN2MtNDcyNi04NjFiLWI4NDIxZDZmZWE1Mi5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTEwM1QwMDE5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01M2YxZTMzYTA5ZmIwYWY2ODEyN2FmNjJjYWFmZTIzZTU4M2ZhZDA0ZWY1ODExMGFiYTBjZmY1Zjk3ZWU2ZjA0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.c0X8zGXjsfbNkDPNM3Qb9JSbOHZNg8ppK_ZyWO8FAMQ)
      
    ](https://private-user-images.githubusercontent.com/127930337/382514988-66cbc743-037c-4726-861b-b8421d6fea52.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA1OTM0NzEsIm5iZiI6MTczMDU5MzE3MSwicGF0aCI6Ii8xMjc5MzAzMzcvMzgyNTE0OTg4LTY2Y2JjNzQzLTAzN2MtNDcyNi04NjFiLWI4NDIxZDZmZWE1Mi5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTEwM1QwMDE5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01M2YxZTMzYTA5ZmIwYWY2ODEyN2FmNjJjYWFmZTIzZTU4M2ZhZDA0ZWY1ODExMGFiYTBjZmY1Zjk3ZWU2ZjA0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.c0X8zGXjsfbNkDPNM3Qb9JSbOHZNg8ppK_ZyWO8FAMQ)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/127930337/382514988-66cbc743-037c-4726-861b-b8421d6fea52.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA1OTM0NzEsIm5iZiI6MTczMDU5MzE3MSwicGF0aCI6Ii8xMjc5MzAzMzcvMzgyNTE0OTg4LTY2Y2JjNzQzLTAzN2MtNDcyNi04NjFiLWI4NDIxZDZmZWE1Mi5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTEwM1QwMDE5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01M2YxZTMzYTA5ZmIwYWY2ODEyN2FmNjJjYWFmZTIzZTU4M2ZhZDA0ZWY1ODExMGFiYTBjZmY1Zjk3ZWU2ZjA0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.c0X8zGXjsfbNkDPNM3Qb9JSbOHZNg8ppK_ZyWO8FAMQ)
    
   [ ![test3](https://private-user-images.githubusercontent.com/127930337/382514988-66cbc743-037c-4726-861b-b8421d6fea52.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA1OTM0NzEsIm5iZiI6MTczMDU5MzE3MSwicGF0aCI6Ii8xMjc5MzAzMzcvMzgyNTE0OTg4LTY2Y2JjNzQzLTAzN2MtNDcyNi04NjFiLWI4NDIxZDZmZWE1Mi5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTEwM1QwMDE5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01M2YxZTMzYTA5ZmIwYWY2ODEyN2FmNjJjYWFmZTIzZTU4M2ZhZDA0ZWY1ODExMGFiYTBjZmY1Zjk3ZWU2ZjA0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.c0X8zGXjsfbNkDPNM3Qb9JSbOHZNg8ppK_ZyWO8FAMQ) ](https://private-user-images.githubusercontent.com/127930337/382514988-66cbc743-037c-4726-861b-b8421d6fea52.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA1OTM0NzEsIm5iZiI6MTczMDU5MzE3MSwicGF0aCI6Ii8xMjc5MzAzMzcvMzgyNTE0OTg4LTY2Y2JjNzQzLTAzN2MtNDcyNi04NjFiLWI4NDIxZDZmZWE1Mi5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTEwM1QwMDE5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01M2YxZTMzYTA5ZmIwYWY2ODEyN2FmNjJjYWFmZTIzZTU4M2ZhZDA0ZWY1ODExMGFiYTBjZmY1Zjk3ZWU2ZjA0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.c0X8zGXjsfbNkDPNM3Qb9JSbOHZNg8ppK_ZyWO8FAMQ)
  
    [
      
        ![test3](https://private-user-images.githubusercontent.com/127930337/382514988-66cbc743-037c-4726-861b-b8421d6fea52.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA1OTM0NzEsIm5iZiI6MTczMDU5MzE3MSwicGF0aCI6Ii8xMjc5MzAzMzcvMzgyNTE0OTg4LTY2Y2JjNzQzLTAzN2MtNDcyNi04NjFiLWI4NDIxZDZmZWE1Mi5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTEwM1QwMDE5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01M2YxZTMzYTA5ZmIwYWY2ODEyN2FmNjJjYWFmZTIzZTU4M2ZhZDA0ZWY1ODExMGFiYTBjZmY1Zjk3ZWU2ZjA0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.c0X8zGXjsfbNkDPNM3Qb9JSbOHZNg8ppK_ZyWO8FAMQ)
      
    ](https://private-user-images.githubusercontent.com/127930337/382514988-66cbc743-037c-4726-861b-b8421d6fea52.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA1OTM0NzEsIm5iZiI6MTczMDU5MzE3MSwicGF0aCI6Ii8xMjc5MzAzMzcvMzgyNTE0OTg4LTY2Y2JjNzQzLTAzN2MtNDcyNi04NjFiLWI4NDIxZDZmZWE1Mi5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTEwM1QwMDE5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01M2YxZTMzYTA5ZmIwYWY2ODEyN2FmNjJjYWFmZTIzZTU4M2ZhZDA0ZWY1ODExMGFiYTBjZmY1Zjk3ZWU2ZjA0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.c0X8zGXjsfbNkDPNM3Qb9JSbOHZNg8ppK_ZyWO8FAMQ)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/127930337/382514988-66cbc743-037c-4726-861b-b8421d6fea52.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA1OTM0NzEsIm5iZiI6MTczMDU5MzE3MSwicGF0aCI6Ii8xMjc5MzAzMzcvMzgyNTE0OTg4LTY2Y2JjNzQzLTAzN2MtNDcyNi04NjFiLWI4NDIxZDZmZWE1Mi5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTEwM1QwMDE5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01M2YxZTMzYTA5ZmIwYWY2ODEyN2FmNjJjYWFmZTIzZTU4M2ZhZDA0ZWY1ODExMGFiYTBjZmY1Zjk3ZWU2ZjA0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.c0X8zGXjsfbNkDPNM3Qb9JSbOHZNg8ppK_ZyWO8FAMQ)
    
   [ ](https://private-user-images.githubusercontent.com/127930337/382514988-66cbc743-037c-4726-861b-b8421d6fea52.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA1OTM0NzEsIm5iZiI6MTczMDU5MzE3MSwicGF0aCI6Ii8xMjc5MzAzMzcvMzgyNTE0OTg4LTY2Y2JjNzQzLTAzN2MtNDcyNi04NjFiLWI4NDIxZDZmZWE1Mi5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTEwM1QwMDE5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01M2YxZTMzYTA5ZmIwYWY2ODEyN2FmNjJjYWFmZTIzZTU4M2ZhZDA0ZWY1ODExMGFiYTBjZmY1Zjk3ZWU2ZjA0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.c0X8zGXjsfbNkDPNM3Qb9JSbOHZNg8ppK_ZyWO8FAMQ)

Can you please upload the complete video for reference , starting from making required changes to the code.

Hi, I'm currently only a member of the PR Review team, so I think I'm not allowed to change code yet. The above is just my suggestion/speculation based on the error.

@Shreyav2000 Shreyav2000 self-requested a review December 12, 2024 04:40
Copy link
Contributor

@Shreyav2000 Shreyav2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jatin,

I reviewed this PR along with the related backend PR and followed the instructions you provided. I updated the server.js file by adding the following lines:

[const { getProfileImagesFromWebsite } = require('./helpers/userHelper');
getProfileImagesFromWebsite();]

After restarting the server and reloading the page (while testing by changing the name to yours), I couldn’t see any image. I’ve attached a video for your reference.

Additionally, the suggested image feature doesn’t seem to fetch relevant suggestions based on the name entered. Instead, it displays the same three images regardless of the name input.

Refer to the video below:

Screen.Recording.2024-12-11.at.11.49.41.PM.mov

@nishitag5 nishitag5 self-requested a review December 13, 2024 06:35
Copy link

@nishitag5 nishitag5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jatin,

I reviewed this PR along with the related backend PR and followed your instructions and recordring. After restarting the server and reloading the page (while testing by changing the from one community teams page), the image is not fetched from the website immediately but I can see the changes reflecting after some time.
As it is a cron job. Is there any schedule for the job to run due to which it is delayed?
I have attached the recording and screenshots below:

PR.2714.1.mp4

image

nishitag5
nishitag5 previously approved these changes Dec 14, 2024
Copy link

@nishitag5 nishitag5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI Jatin,
After taking your changes and following the steps mentioned, I changed the name in the user profile to match with the team member's name available on the One Community website. Then I restarted the server and waited for 5-7 minutes to refresh the profile page. On refreshing the page, I am able to see the profile image based on the user name given in the profile page.
The changes are working as expected. Please find the recording below:

Recording.2024-12-14.010607.mp4

@JatinAgrawal94 JatinAgrawal94 dismissed stale reviews from audreydieuanh and Rupa2400 December 14, 2024 22:39

Fixed changes, waited for re-review for too long.

Shreyav2000
Shreyav2000 previously approved these changes Dec 21, 2024
Copy link
Contributor

@Shreyav2000 Shreyav2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jatin,

I reviewed your PR again and I'm ready to approve these changes, as everything is working correctly now. Initially, I thought the changes (particularly the profile image being fetched from the One Community website) would reflect immediately, but I see now that it takes a couple of minutes.

Copy link

@Sheehan20 Sheehan20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JatinAgrawal94, great work on implementing the profile image fetching feature! Here are my observations:

  1. Feature Highlights:
  • Added ability to fetch profile images from the One Community website
  • Implemented modal for suggested profile images
  • Created confirmation modal for image removal
  • Enhanced user profile image management
  1. Key Components Added:
  • suggestedProfileModal.js: Modal for displaying suggested profile images
  • confirmRemoveModal.js: Modal for confirming profile image removal
  • Updated UserProfile.jsx to support new image selection and removal workflows
  1. Notable Technical Implementations:
  • Added endpoints for profile image management
  • Implemented image conversion to base64
  • Added toast notifications for image updates
  • Graceful handling of profile image scenarios
  1. Observations & Suggestions:
  • The feature seems to have a slight delay in image fetching (as noted by reviewers)
  • Recommended adding error handling for image conversion
  • Consider adding loading states during image fetch/update
  1. Testing Recommendations:
  • Verify image fetching works across different user profiles
  • Test edge cases like no suggested images
  • Ensure smooth cross-browser compatibility

Overall, this is a solid implementation that enhances user profile customization. Great job on the detailed implementation!

Copy link

@honglinchen0524 honglinchen0524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profile page isn't loading for some reason. Here is the video (including the code I added following the backend PR instructions):

PR2714.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.