Tapan - Fixed UI for Create New Role Without Name and Permission

[TapanPathak]

Description

Demo of Bug - https://www.dropbox.com/scl/fi/ei3ag16xb57isrx2ek7ak/Create-new-role-click-with-empty-fields-white-screen.mp4?rlkey=vb01psyvwwwmeyoigwmm1x1j7&e=1&dl=0

Related PRS (if any):

N/A
…

Main changes explained:

• Fixed UI for handling new role request when rolename and permission are empty
• Role Name needs to be given
• Atleast one permission needs be to selected

How to test:

1. check into current branch
2. do npm install and ... to run this PR locally
3. Clear site data/cache
4. log as owner user
5. Other Links -> Permissions Management -> Add New Role -> Create
6. Try to create a role without giving rolename and without selecting any permission, it should thrown an error in UI.

Screenshots or videos of changes:

Screen.Recording.2024-03-05.at.3.21.07.PM.mov

[lacnoskillz]

Hello @TapanPathak
I have pulled your changes and tested your code and it works as described. Nice work!
I attempted to make a role on dev without a name/role selected and the page goes blank

but with your changes the proper checks prevent that from happening nice catch!
See below video of successful role create.

2024-03-07.21-07-52.mp4

[Gugor99]

Report

Hi Tapan,
I tried to review your PR but compilation failed and I got an error message in the console. Please see screenshot for reference.

Screenshot

[meetpadhiar4]

Hi, I tested your PR and it works as intended. The role validation works fine and passed all the test cases. Please refer the video attached.

PR.2031.mov

[dhairya-mehta]

Hey Tapan, I tested and verified the PR, while checking the popup check

[nnamdixobi]

Everything compiled correctly but I was unable to see the button to add a new role

[yaow62023]

Hi, I have test your PR. The error message though out when no role name or no Permissions selected. Check the video below:

2031.mp4

[mohabbasd]

Hello, I tested you PR and it works perfectly. Great Job! Below is a video for your reference.

Screen.Recording.2024-03-23.at.11.48.33.PM.mov

[MQChen211]

Hi, I tested your PR and it works as expected.

[SushmithaPrathap]

Hey, I've gone through the PR and tested it according to the steps you provided. Tried out different combinations and everything works smoothly. Also, it correctly notifies if the role name already exists. Nicely done!

Here is the screen recording:

Screen.Recording.2024-04-04.at.10.17.52.PM.mov

[Jaiwin-4998]

Hi, I just reviewed your PR and is working fine.

[SRamen1999]

Everything works as expected. When create a role without giving role name and without selecting any permission, it throws an error. Also, it correctly notifies if the role name already exists.

Screen.Recording.2024-04-05.at.9.30.11.AM.mov

Screen.Recording.2024-04-05.at.9.32.09.AM.mov

[anandsesha]

Hi, I tested your PR, and its working as expected. Role name and at least one permission needed, else shows appropriate UI error.

[MQChen211]

Hi, I tested your PR and all works as expected.

[KurtisIvey]

Approved. Everything functions as it should without any errors on the front or backend. Code changes are minimal while still accomplishing the desired fix. Photos attached for verification of clean error popup when criteria not met for creating new role.

Fantastic job!

[one-community]

Thank you all, merging!