Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapan - Fixed UI for Create New Role Without Name and Permission #2031

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Tapan - Fixed UI for Create New Role Without Name and Permission #2031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3c9e75
Tapan - Fixed the UI for creating a new role without required roleNam…
Mar 5, 2024
3139c49
Tapan - Fixed UI code
Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/PermissionsManagement/NewRolePopUp.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ function CreateNewRolePopup({ toggle, addNewRole, roleNames }) {
const handleSubmit = async e => {
e.preventDefault();

if (!isValidRole) {
if (newRoleName.trim() === '') {
toast.error('Please enter a role name');
} else if (permissionsChecked.length === 0) {
toast.error('Please select at least one permission');
} else if (!isValidRole) {
toast.error('Please enter a valid role name');
} else if (!isNotDuplicateRole) {
toast.error('Please enter a non duplicate role name');
Expand All @@ -38,6 +42,7 @@ function CreateNewRolePopup({ toggle, addNewRole, roleNames }) {
const regexTest = noSymbolsRegex.test(value);
const duplicateTest = checkIfDuplicate(value);
if (value.trim() === '') {
/* Changes Made */
setNewRoleName(value);
setErrorMessage('Please enter a role name');
setIsValidRole(false);
Expand Down
Loading