Ruleset: prevent false positives on polyfill code #2
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When notifying the polyfill repos about the polyfill rulesets, I came across this issue and figured we could fix that.
When
PHPCompatibility(PasswordCompat)
is run over the code in thepassword_compat
repo itself, it will detect some non-issues.The code in the
lib/password.php
file is all wrapped withindefined()
and/orfunction_exists()
conditions and will never be executed on PHP 5.5+ as the functionality being polyfilled is by then provided natively by PHP.This simple change prevents these non-issues from being reported.
This fix does rely on people having installed the code in a directory called
password_compat
or, for composer installspassword-compat
.