Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gz: increase timeout for service request #24164

Merged
merged 3 commits into from
Jan 21, 2025
Merged

gz: increase timeout for service request #24164

merged 3 commits into from
Jan 21, 2025

Conversation

dakejahl
Copy link
Contributor

@dakejahl dakejahl commented Jan 3, 2025 •
edited
Loading

Closes #23705
Closes #23809

@dakejahl dakejahl mentioned this pull request Jan 3, 2025
Closed
@leechor
Copy link

leechor commented Jan 3, 2025

Closes #23705 Closes #23809

it works for me, by the way, line 915 maybe modified too.

@dakejahl dakejahl requested a review from Jaeyoung-Lim January 15, 2025 05:52
Jaeyoung-Lim
Jaeyoung-Lim requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is called on a loop. Wouldn't it make sense to modify the user message that it is retrying, rather than increase the timeout?

@dakejahl
Copy link
Contributor Author

This is called on a loop. Wouldn't it make sense to modify the user message that it is retrying, rather than increase the timeout?

I think not having the warning in the first place is optimal. I also updated the text and changed from err to warn

@dakejahl dakejahl force-pushed the pr-gz_service_timeout_fix branch from 2467418 to b1f3a94 Compare January 17, 2025 21:08
@dakejahl dakejahl mentioned this pull request Jan 21, 2025
Closed
@dakejahl dakejahl enabled auto-merge (squash) January 21, 2025 20:19
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-jan-22-2025/43384/3

Jaeyoung-Lim
Jaeyoung-Lim approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dakejahl dakejahl merged commit 918eca8 into PX4:main Jan 21, 2025
55 of 57 checks passed
@dakejahl dakejahl deleted the pr-gz_service_timeout_fix branch January 21, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaeyoung-Lim Jaeyoung-Lim Jaeyoung-Lim approved these changes

@dagar dagar Awaiting requested review from dagar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dakejahl @leechor @DronecodeBot @Jaeyoung-Lim