-
-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored & removed instances of jest in scripts #3526
Refactored & removed instances of jest in scripts #3526
Conversation
WalkthroughThe pull request updates documentation and mock functionality. In the docs, the function definition locations in the OrgList and OrganizationModal components have been revised with adjusted line numbers, and the OrgList documentation has been streamlined by removing CSS strategy details. In addition, the mocks for the Dicebear modules have been updated to replace Jest’s Changes
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docs/docs/auto-docs/screens/OrgList/OrgList/functions/default.md
(1 hunks)docs/docs/auto-docs/screens/OrgList/OrganizationModal/functions/default.md
(1 hunks)docs/docs/auto-docs/screens/OrgList/OrganizationModal/interfaces/InterfaceOrganizationModalProps.md
(7 hunks)scripts/__mocks__/@dicebear/collection.ts
(1 hunks)scripts/__mocks__/@dicebear/core.ts
(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- scripts/mocks/@dicebear/collection.ts
- docs/docs/auto-docs/screens/OrgList/OrganizationModal/functions/default.md
- docs/docs/auto-docs/screens/OrgList/OrgList/functions/default.md
- docs/docs/auto-docs/screens/OrgList/OrganizationModal/interfaces/InterfaceOrganizationModalProps.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test Application
🔇 Additional comments (1)
scripts/__mocks__/@dicebear/core.ts (1)
1-1
: LGTM! Correct import for Vitest mocking.The import statement correctly brings in the Vitest mocking functionality, aligning with the PR's objective to remove Jest.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3526 +/- ##
====================================================
- Coverage 88.65% 88.61% -0.04%
====================================================
Files 341 341
Lines 8626 8627 +1
Branches 1925 1925
====================================================
- Hits 7647 7645 -2
- Misses 635 638 +3
Partials 344 344 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/setupTests.ts
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test Application
🔇 Additional comments (1)
src/setupTests.ts (1)
1-5
: Verify the Jest dependencies after migration to Vitest.The file still uses Jest-specific packages (
@testing-library/jest-dom
andjest-preview
) while migrating to Vitest. This mixed usage might lead to conflicts or unexpected behavior.Run this script to check for Vitest-compatible alternatives:
Also applies to: 21-21, 30-33
1183dfc
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Refactorung
Issue Number:
Fixes #3525
Snapshots/Videos:
N/A
If relevant, did you update the documentation?
No
Summary
Refactored & removed instances of jest in scripts folder.
Does this PR introduce a breaking change?
No
Checklist
CodeRabbit AI Review
Test Coverage
Other information
the docs were generated during the commit.
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Documentation
Tests