Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vivado2023 Upgrade #174

Merged
merged 7 commits into from
Mar 14, 2024
Merged

Vivado2023 Upgrade #174

merged 7 commits into from
Mar 14, 2024

Conversation

glennchid
Copy link
Contributor

@glennchid glennchid commented Feb 7, 2024

Vivado 2023.2 upgrade

Issues encountered:

  • Vivado build consistently seg faulting when run inside container. Related to licensing bug: https://support.xilinx.com/s/question/0D54U00005Sgst2SAB/failed-batch-mode-execution-in-linux-docker-running-under-windows-host?language=en_US. Workarounds: run vivado with LD_PRELOAD pointing to libudev.so.1 or pass through host networking stack into container (--net-host) - the latter is preferable if it works under CI.
  • IRQ sensitivity defaulting to disallowed value for zynqmp - all targets changed to EDGE_RISING for consistency
  • Kernel build failed when using previous config for zynqmp - removing unused features fixes build
  • Verilog testbenches need renaming to .sv for changes to verilog 2-d array handling in vivado
  • Bug introduced into fscanf function in verilog, failing to parse multiple negative numbers: https://support.xilinx.com/s/question/0D54U000080bmlESAQ/sscanf-and-fscanf-broken-in-vivado-20232-when-parsing-negative-numbers?language=en_US
  • For unknown reason, labels for temperature and voltage sensors in sysfs changed for zynqmp device, but not for zynq-7000. I think the new labels correspond to the the same sensors that were previously monitored. There seem to be several voltage and temperature sensors available, so we may want to review the optimal choice for zynqmp.
  • Devicetree change for SD card that was found to be necessary for PandABrick with earlier version of vivado (6f27fba) was not found to be necessary for xu5_st1. May have been a consequence of faulty SD card or cage on ST1, or different version of vivado/kernel.

NB: Draft PR subject to all sites being ready to upgrade. Merge needs to be made in concert with PR in PandA-rootfs repo:
PandABlocks/PandABlocks-rootfs#44

* Remove some unused variables
* Give more meaningful names to Vivado run-mode variables
* Comment out variables in CONFIG.example which use default values
* to be consistent with the header message.
* Changing testbenches from .v to .sv due to changes in array handling
* Using bitmask to convert values to 32-bit unsigned representation
* as work-around for fscanf bug in vivado simulator see:
* https://support.xilinx.com/s/question/0D54U000080bmlESAQ/sscanf-and-fscanf-broken-in-vivado-20232-when-parsing-negative-numbers?language=en_US
Makefile Show resolved Hide resolved
EmilioPeJu
EmilioPeJu previously approved these changes Feb 8, 2024
valerixb
valerixb previously approved these changes Feb 9, 2024
@glennchid glennchid dismissed stale reviews from valerixb and EmilioPeJu via 6a33f61 February 14, 2024 17:32
@glennchid glennchid marked this pull request as ready for review March 11, 2024 17:08
@tomtrafford tomtrafford merged commit 717a0f2 into master Mar 14, 2024
24 checks passed
@glennchid glennchid deleted the vivado2023 branch April 5, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants