-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vivado2023 Upgrade #174
Merged
Merged
Vivado2023 Upgrade #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove some unused variables * Give more meaningful names to Vivado run-mode variables * Comment out variables in CONFIG.example which use default values * to be consistent with the header message.
* Changing testbenches from .v to .sv due to changes in array handling * Using bitmask to convert values to 32-bit unsigned representation * as work-around for fscanf bug in vivado simulator see: * https://support.xilinx.com/s/question/0D54U000080bmlESAQ/sscanf-and-fscanf-broken-in-vivado-20232-when-parsing-negative-numbers?language=en_US
EmilioPeJu
reviewed
Feb 8, 2024
EmilioPeJu
reviewed
Feb 8, 2024
EmilioPeJu
previously approved these changes
Feb 8, 2024
valerixb
previously approved these changes
Feb 9, 2024
6a33f61
to
6516720
Compare
tomtrafford
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vivado 2023.2 upgrade
Issues encountered:
LD_PRELOAD
pointing tolibudev.so.1
or pass through host networking stack into container (--net-host
) - the latter is preferable if it works under CI.PandABrick
with earlier version of vivado (6f27fba) was not found to be necessary forxu5_st1
. May have been a consequence of faulty SD card or cage on ST1, or different version of vivado/kernel.NB: Draft PR subject to all sites being ready to upgrade.
Merge needs to be made in concert with PR in PandA-rootfs repo:PandABlocks/PandABlocks-rootfs#44