-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tanks] Add interrupt into the combos, [Core] Rework settings tab #316
Open
zbee
wants to merge
9
commits into
PunishXIV:main
Choose a base branch
from
zbee:tanks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+314
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of a strict amount of time; nobody used this param, likely because it becomes impossible to really account for the very short interruptable casts around level 50
zbee
added
New Feature
This adds a new option or feature
Adjustments
This will adjust something inside a rotation, feature, or core function
labels
Jan 26, 2025
zbee
requested review from
Taurenkey,
Akechi-kun and
Kaeris-Tempest
as code owners
January 26, 2025 21:41
Changed Files
|
zbee
added a commit
to zbee/WrathCombo
that referenced
this pull request
Feb 3, 2025
from PunishXIV#316 originally
43 tasks
@Akechi-kun would you be able to give this a test perhaps? |
zbee
added a commit
to zbee/WrathCombo
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Adjustments
This will adjust something inside a rotation, feature, or core function
New Feature
This adds a new option or feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ST: added option to interject if the target's cast is interruptible
ST Simple: interrupts if the target's cast is interruptible
AoE: added options to interject if the target's cast is interruptible, or to stun if the target is casting
AoE Simple: interrupts if the target's cast is interruptible, and stuns if the target is casting
Shield Bash
in the Stun option, in addition toLow Blow
)Which delays interrupts by X% of the total cast.
If a value is not passed to
CanInterruptEnemy()
then it will use this setting, and only returntrue
if the cast is over that percentage done.