Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tanks] Add interrupt into the combos, [Core] Rework settings tab #316

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

zbee
Copy link
Member

@zbee zbee commented Jan 26, 2025

  • Adds Interrupting to all tanks' combos
    ST: added option to interject if the target's cast is interruptible
    ST Simple: interrupts if the target's cast is interruptible
    AoE: added options to interject if the target's cast is interruptible, or to stun if the target is casting
    AoE Simple: interrupts if the target's cast is interruptible, and stuns if the target is casting
  • Adds new Setting for Interrupt Delay.
    Which delays interrupts by X% of the total cast.
    If a value is not passed to CanInterruptEnemy() then it will use this setting, and only return true if the cast is over that percentage done.
  • Reworked the settings tab. Was getting cramped.
    new settings tab

zbee added 6 commits January 26, 2025 12:25
instead of a strict amount of time;
nobody used this param, likely because it becomes impossible to really account for the very short interruptable casts around level 50
@zbee zbee added New Feature This adds a new option or feature Adjustments This will adjust something inside a rotation, feature, or core function labels Jan 26, 2025
Copy link

semanticdiff-com bot commented Jan 26, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  WrathCombo/CustomCombo/Functions/Target.cs  48% smaller
  WrathCombo/Window/Tabs/Settings.cs  13% smaller
  WrathCombo/Combos/CustomComboPreset.cs  1% smaller
  WrathCombo/Combos/PvE/GNB/GNB.cs  0% smaller
  WrathCombo/Combos/PvE/PLD/PLD.cs  0% smaller
  WrathCombo/Combos/PvE/WAR/WAR.cs  0% smaller
  WrathCombo/Core/PluginConfiguration.cs  0% smaller

zbee added a commit to zbee/WrathCombo that referenced this pull request Feb 3, 2025
@zbee
Copy link
Member Author

zbee commented Feb 4, 2025

@Akechi-kun would you be able to give this a test perhaps?

zbee added a commit to zbee/WrathCombo that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adjustments This will adjust something inside a rotation, feature, or core function New Feature This adds a new option or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant