[DRK] Simple Modes, In-Rotation Mit expansion, Rework

[zbee]

Tip

See this discord post for a more visual list of what is being added in this PR, and for any feedback about this PR.

Log Snippet comparisons:

• NEW Advanced mode
• NEW Simple mode
• Old Advanced mode

• Rework most action logic into TryGet methods like RDM uses

  • oGCDs
    • (Try to mitigate Triple-Weaving to close this discord post)
    • Variant Actions
    • Mitigation
    • Mana-Spenders
      • Overcap protection
      • Improve Dark Arts logic (to close this discord post)
      • Darkside maintenance
      • Burst usage
    • Cooldowns
      • (new option to restrict all CDs to boss fights)
      • Disesteem
      • Living Shadow
      • Interrupting (from [Tanks] Add interrupt into the combos, [Core] Rework settings tab #316 originally)
      • Delirium
      • Salted Earth
        • Salt and Darkness
        • Separate Salt and Darkness from Salted Earth (to close this discord post)
      • Shadowbringer
      • Carve and Spit
      • Abyssal Drain
  • GCDs
    • Blood Overcap
    • Delirium Combo
    • Pre-Burst Blood maintenance
    • Blood Burst usage (low level)
    • 1-2-3 combos

• Expand in-rotation mitigation options

  • Oblation
  • Reprisal
  • Dark Missionary
  • Rampart
  • Arms Length

• Add Simple Modes

  • Single-Target
  • AoE

• Fix [DRK] advanced mode options #89, Fix [DRK] quietus on advanced mode delirium #205

  • Separate Blood abilities/Delirium combo from Delirium
  • Make sure oGCD feature is up to date
  • Add slider for AoE Blood overcap option
    • And for the ST overcap option

• Reorganize all ST and AoE presets

• Reset DRK options

• Add HP% sliders

[moreime]

would it be possible to separate shadowbringers from disesteem as well?

[zbee]

@moreime I'm fairly certain it never was, but it certainly is detached now, yes.

[moreime]

it was when i tried it a few weeks ago, i disabled disesteem option and it wouldnt use shadowbringers until disesteem was used. but thankies, great work on drk in general

[zbee]

@moreime this is effectively already done with the new Shadowbringer logic. There was a bug with it before.

However, the Shadowbringer Burst Option will still wait for Disesteem to be used before using Shadowbringer.
There's not a good way to change this logic, without overengineering it, I believe, so it will stay that way, but I will make that more clear.

[zbee]

@Kagekazu would appreciate your review, but mostly pinging you because I think you might like to pull this branch and see how I made DRK similar to RDM, with all the logic moved out of the actual rotations to be easier to maintain (hopefully).

For example, on the left is a preview of the new Simple Mode, and the right is the code for "cooldown" actions:

[Kagekazu]

@Kagekazu would appreciate your review, but mostly pinging you because I think you might like to pull this branch and see how I made DRK similar to RDM, with all the logic moved out of the actual rotations to be easier to maintain (hopefully).

I will have a look, thanks!