Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating test vectors for Action Groups #24

Open
wants to merge 8 commits into
base: zsa1
Choose a base branch
from

Conversation

vivek-arte
Copy link

@vivek-arte vivek-arte commented Dec 2, 2024

This PR makes the changes corresponding to the updates in the V6 transaction format and digest computation, especially for the update to include Action Groups.

Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall. Added some comments, mostly cosmetics for this PR and the zip.

zcash_test_vectors/orchard_zsa/digests.py Outdated Show resolved Hide resolved
zcash_test_vectors/orchard_zsa/digests.py Outdated Show resolved Hide resolved
zcash_test_vectors/orchard_zsa/digests.py Outdated Show resolved Hide resolved
zcash_test_vectors/orchard_zsa/digests.py Outdated Show resolved Hide resolved
zcash_test_vectors/orchard_zsa/digests.py Outdated Show resolved Hide resolved
zcash_test_vectors/transaction_v6.py Show resolved Hide resolved
zcash_test_vectors/transaction_v6.py Outdated Show resolved Hide resolved
zcash_test_vectors/transaction_v6.py Outdated Show resolved Hide resolved
zcash_test_vectors/transaction_v6.py Show resolved Hide resolved
zcash_test_vectors/transaction_v6.py Show resolved Hide resolved
PaulLaux pushed a commit to QED-it/librustzcash that referenced this pull request Jan 20, 2025
…94)

This PR makes the changes to the test vectors that have been made in
QED-it/zcash-test-vectors#24, to reflect the
updated transaction format that uses Action Groups, and the updated
computations for the SIGHASH and the Authorizing Data Commitment.
PaulLaux
PaulLaux previously approved these changes Jan 28, 2025
Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending minor comments.

zcash_test_vectors/transaction_v6.py Outdated Show resolved Hide resolved
zcash_test_vectors/transaction_v6.py Show resolved Hide resolved
zcash_test_vectors/transaction_v6.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants