Updating digest names #95
Conversation
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| The personalization field remains the same as in ZIP 244 [#zip-0244]_, namely:: | ||
|
|
||
| "ZcashTxHash_" || CONSENSUS_BRANCH_ID |
There was a problem hiding this comment.
Can you elaborate on this?
I don't remember seeing such thing anywere in the code.
There was a problem hiding this comment.
It is in librustzcash: See here.
There was a problem hiding this comment.
To elaborate: We didn't expand on this in the ZIP since originally this top level branch is the same as in ZIP 244, we had only added a new sub branch for issuance. Now we are expanding it a bit because we are replacing orchard_digest with orchard_zsa_digest and adding the issuance_digest branch.
Implementation wise as well, the personalization of "ZcashTxHash_" || CONSENSUS_BRANCH_ID wasn't actively changed (and still isn't).
There was a problem hiding this comment.
The alternative is to just mention it is unchanged from ZIP 244, without mentioning what it is
This PR performs various improvements to the naming of the branches of the TxID and Signature Digests, and the Authorizing Data Commitment, as initially suggested in the review of QED-it/zcash-test-vectors#24.