Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating test vectors for Action Groups #24

Merged
merged 9 commits into from
Feb 6, 2025
Merged

Updating test vectors for Action Groups #24

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
07758da
updating to add Action Groups
vivek-arte Dec 1, 2024
070a2e4
adding generated test vectors
vivek-arte Dec 2, 2024
832acf7
updating NU7 branch ID
vivek-arte Dec 17, 2024
8f3dfde
updating NU7 branch ID and version group ID
vivek-arte Dec 17, 2024
400a386
making some fixes, and updating generated vectors
vivek-arte Jan 13, 2025
ae2d95e
trying to fix CI tests
vivek-arte Jan 17, 2025
3076595
responding to review comments
vivek-arte Jan 28, 2025
51c284b
edits to resolve issues
vivek-arte Jan 30, 2025
f172909
fix based on review comment
vivek-arte Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions zcash_test_vectors/transaction_v6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,10 @@ def __init__(self, rand, anchor_orchard, proofs_orchard, is_coinbase):
# There must always be a non-zero number of Action Descriptions in an Action Group.
for _ in range(rand.u8() % 4 + 1):
self.vActionsOrchard.append(OrchardZSAActionDescription(rand))
# Three flag bits are defined, we set enableZSA to true.
self.flagsOrchard = (rand.u8() & 7) | 4
# Three flag bits are defined, ensure the other bits are zero by masking.
vivek-arte marked this conversation as resolved.
Show resolved Hide resolved
self.flagsOrchard = (rand.u8() & 7)
# Set the enableZSAs flag to true by OR with 0b00000100
self.flagsOrchard |= 4
if is_coinbase:
# set enableSpendsOrchard = 0
vivek-arte marked this conversation as resolved.
Show resolved Hide resolved
self.flagsOrchard &= 2
vivek-arte marked this conversation as resolved.
Show resolved Hide resolved
Expand Down