forked from ZcashFoundation/zebra
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracks issued assets state and contextually validates issue actions and asset burns #26
Open
arya2
wants to merge
10
commits into
zsa-integration-issuance-commitments
Choose a base branch
from
zsa-issued-assets
base: zsa-integration-issuance-commitments
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
force-pushed
the
zsa-issued-assets
branch
from
November 12, 2024 07:48
9f5cb45
to
3d00b81
Compare
arya2
force-pushed
the
zsa-issued-assets
branch
2 times, most recently
from
November 12, 2024 08:13
902bfa6
to
44dd204
Compare
arya2
force-pushed
the
zsa-issued-assets
branch
from
November 12, 2024 08:24
44dd204
to
2daf84f
Compare
arya2
commented
Nov 12, 2024
zebra-state/src/service/finalized_state/disk_format/shielded.rs
Outdated
Show resolved
Hide resolved
…callyVerifiedBlock types, updates `IssuedAssetsChange::from_transactions()` method return type
…heckpointVerifiedBlock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks issued assets in Zebra's state and uses that state to contextually validate issue actions and asset burns.
It still needs tests, additional documentation, cleanup, and to track information for creating split notes.
Review
This PR may be easier to review by commit.