-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Inactive Clients Not Refreshing Action Buttons After App Deployment #34849
fix: Inactive Clients Not Refreshing Action Buttons After App Deployment #34849
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bb7bfa7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34849 +/- ##
===========================================
+ Coverage 59.12% 59.16% +0.03%
===========================================
Files 2819 2819
Lines 67939 67779 -160
Branches 15134 15078 -56
===========================================
- Hits 40172 40099 -73
+ Misses 24934 24859 -75
+ Partials 2833 2821 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
@Harmeet221 gave us her blessing on this one. |
Proposed changes (including videos or screenshots)
Currently, when the app is redeployed, active clients properly fetch and display the updated action buttons (via GET /apps/actionButtons). However, any clients that were inactive during the deployment (e.g., a laptop in sleep mode) do not fetch the updated list upon becoming active again. As a result, these inactive clients continue using outdated actionIds, causing inconsistent and potentially broken interactions.
So now, everytime the client goes offline, we invalidate the cache, since the buttons might have changed in the meantime
Issue(s)
Steps to test or reproduce
Start with the client active and confirm it fetches updated action buttons upon deployment.
Put the client into an inactive state (e.g., close laptop lid or simulate a network disconnection), then redeploy the app.
Reactivate the client and verify that it immediately retrieves the updated action buttons list.
Repeat steps 2-3 for multiple clients to ensure consistent behavior across different endpoints and environments.
Note: You can use
Meteor.disconnect
to test socket reconnectionFurther comments
CONN-434