Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inactive Clients Not Refreshing Action Buttons After App Deployment #34849

Merged
merged 10 commits into from
Jan 13, 2025
Merged

fix: Inactive Clients Not Refreshing Action Buttons After App Deployment #34849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cbb22b1
fix: invalidate the cache when we disconnect the socket
Gustrb Dec 30, 2024
187a088
Create eleven-pugs-help.md
Gustrb Dec 30, 2024
04d62ff
chore: add import
Gustrb Dec 30, 2024
e6795fc
chore: remove odd commend
Gustrb Dec 30, 2024
b025392
Merge branch 'develop' into fix/invalidate-apps-buttons-cache-on-sock…
Gustrb Jan 9, 2025
f7fb2c3
chore: use already existing hook
Gustrb Jan 9, 2025
37ba13d
feat: use react-query props
Gustrb Jan 9, 2025
b6fef0e
Update eleven-pugs-help.md
gabriellsh Jan 9, 2025
637e493
Merge branch 'develop' into fix/invalidate-apps-buttons-cache-on-sock…
kodiakhq[bot] Jan 13, 2025
bb7bfa7
Merge branch 'develop' into fix/invalidate-apps-buttons-cache-on-sock…
kodiakhq[bot] Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eleven-pugs-help.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixes an issue where losing connection could break app's action buttons
7 changes: 4 additions & 3 deletions apps/meteor/client/hooks/useAppActionButtons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
import { type IUIActionButton, type UIActionButtonContext } from '@rocket.chat/apps-engine/definition/ui';
import { useDebouncedCallback } from '@rocket.chat/fuselage-hooks';
import { useEndpoint, useStream, useUserId } from '@rocket.chat/ui-contexts';
import { useConnectionStatus, useEndpoint, useStream, useUserId } from '@rocket.chat/ui-contexts';
import { useQuery, useQueryClient } from '@tanstack/react-query';
import { useEffect } from 'react';

export const getIdForActionButton = ({ appId, actionId }: IUIActionButton): string => `${appId}/${actionId}`;

export const useAppActionButtons = <TContext extends `${UIActionButtonContext}`>(context?: TContext) => {
const queryClient = useQueryClient();

const apps = useStream('apps');
const uid = useUserId();
const { status } = useConnectionStatus();

const getActionButtons = useEndpoint('GET', '/apps/actionButtons');

const result = useQuery({
queryKey: ['apps', 'actionButtons'],
queryKey: ['apps', 'actionButtons', status],
enabled: status === 'connected',
queryFn: () => getActionButtons(),

...(context && {
Expand Down
Loading