Test orthanc-raw behaves correctly when storage limit reached #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set maximum storage to 40MB which is enough to contain the starting test instances.
Image headers are derived from a real 3D-T1 from a Philips scanner. The site and patient specific information has been anonymised and the pixel data replaced with random noise.
5 tasks
milanmlft
approved these changes
Feb 6, 2024
stefpiatek
reviewed
Feb 6, 2024
We need pydicom to run the orthanc-raw capacity test. For now installing it while other pip installs are happening is ok but a package of test utils and dependencies might be better.
HChughtai
requested changes
Feb 6, 2024
HChughtai
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Thanks for the changes @jstutters, happy to approve this now.
I agree around your comment that we need to flesh out our testing strategy, and then can reevaulate how some of this is best done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utility code to generate fake MRI DICOMs and upload these to orthanc-raw for testing that older instances are cycled out. Addresses a requirement of #205.