Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test orthanc-raw behaves correctly when storage limit reached #278

Merged
merged 20 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/services/ftp-server.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ in the `.env` file (see [the example](../.env.sample)).

For the `pixl_core` unit tests and the system test, we spin up an FTPS server with a Docker
container, defined in [`test/dummy-services/ftp-server`](../../test/dummy-services/ftp-server/) and
set the necessary environment variables in [`.env.test`](../../test/.env.test).
set the necessary environment variables in [`test/.env`](../../test/.env).

## FTPS test server

Expand Down
2 changes: 1 addition & 1 deletion test/.env.test → test/.env
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ ORTHANC_RAW_USERNAME=orthanc_raw_username
ORTHANC_RAW_PASSWORD=orthanc_raw_password
ORTHANC_RAW_AE_TITLE=ORTHANCRAW
ORTHANC_AUTOROUTE_RAW_TO_ANON=true
ORTHANC_RAW_MAXIMUM_STORAGE_SIZE=100
ORTHANC_RAW_MAXIMUM_STORAGE_SIZE=40

# PIXL Orthanc anon instance
ORTHANC_ANON_USERNAME=orthanc_anon_username
Expand Down
5 changes: 3 additions & 2 deletions test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ as the FTP client. The Docker container requires the following environment varia
- `TLS_KEY`: keyfile for the TLS certificate
- `TLS_CERT`: TLS certificate

> [!warning] The `ADDRESS` should match the `FTP_HOST` environment variable defined in `.env.test`,
> [!warning] The `ADDRESS` should match the `FTP_HOST` environment variable defined in `.env`,
> otherwise FTP commands such as `STOR` or `dir` run from other Docker containers in the network
> (such as `orthanc-anon`) will fail. _Note: connecting and logging into the FTP server might still
> work, as the address name is only checked for protected operations such as listing and transfering
Expand All @@ -64,7 +64,8 @@ and are copied into `/etc/ssl/private` when building the Docker container.

### Resources

- `./resources/` provides 2 mock DICOM images used to populate the mock VNA.
- `./resources/` provides 2 mock DICOM images used to populate the mock VNA
and a JSON file of slice varying parameters from a 3D MRI sequence.
- `./resources/omop` contains mock public and private Parquet files used to populate the message
queues and extract the radiology reports

Expand Down
Loading
Loading