Design Review Findings

[droshev]

Components with issues:

• Calendar - Mike fix(styles): calendar updates [ci visual] #4930

• Card - Mike fix(styles): card updates #4933

• Carousel - Mike fix(styles): carousel updates #4935

• Dialog - Mike docs(styles): dialog updates #4937

• Generic Tag - Giorgi fix(styles): design review finding fixes for generic tag and object status #4968

• Link - N1XUS

• Message Popover - N1XUS

• Message Strip - Mike docs(styles): bold link in message strip docs #4948

• Object List - Giorgi

• Object Marker - text color checked and confirmed

• Object Status- Giorgi fix(styles): design review finding fixes for generic tag and object status #4968

• Panel - Mike docs(styles): make panel button work, rename function [ci visual] #4949

• Popover - Mike fix(styles): popover updates, and do not use menu in popover examples #4950

• Progress Indicator- Giorgi

• Select - N1XUS fix(styles): input and select disabled placeholder #4932

• Splitter - Mike

[g-cheishvili]

Progress indicator popover note:

This popover comes from fiori specifications, the Horizon does not have any mentioning of the truncation. On UI5, they just truncate, without any popover. In general they should not share the same HTML structure, but we're forced to make them the same

Object list note:

The spacing between the attributes is 0.5 rem already. When they say "inner padding" they mean the spacing between the attribute and the status.
Visually they might not appear distanced from each other with 0.5rem, because there is also a line-height specification, which states that it should have 1.5 line height and naturally the height of the text is increased