Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): card updates #4933

Closed
wants to merge 7 commits into from
Closed

fix(styles): card updates #4933

wants to merge 7 commits into from

Conversation

mikerodonnell89
Copy link
Member

part of #4912

@mikerodonnell89 mikerodonnell89 added this to the Sprint 124 milestone Oct 27, 2023
@mikerodonnell89 mikerodonnell89 requested a review from a team October 27, 2023 15:54
@mikerodonnell89 mikerodonnell89 self-assigned this Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 4e48c78
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/653bdd20d12a660007f09abf
😎 Deploy Preview https://deploy-preview-4933--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 27, 2023 •
edited
Loading

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 140d31b
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/65524b355df2e80008ad1358
😎 Deploy Preview https://deploy-preview-4933--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mikerodonnell89 mikerodonnell89 mentioned this pull request Oct 27, 2023
Closed
16 tasks
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 124, Sprint 125 Oct 27, 2023
InnaAtanasova
InnaAtanasova requested changes Oct 31, 2023
View reviewed changes
packages/styles/src/card.scss Outdated Show resolved Hide resolved
packages/styles/src/card.scss Outdated Show resolved Hide resolved
packages/styles/src/card.scss Outdated Show resolved Hide resolved
@InnaAtanasova
Copy link
Contributor

@mikerodonnell89 could you trigger the visual updates with [ci visual]?

@InnaAtanasova
Copy link
Contributor

@mikerodonnell89 please trigger the visual checks

@InnaAtanasova InnaAtanasova modified the milestones: Sprint 125, Sprint 126 Nov 10, 2023
@droshev droshev self-requested a review November 17, 2023 22:45
droshev
droshev requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@droshev droshev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some vertical misalignments (subtitle and currency)

Screenshot 2023-11-15 at 5 10 16 PM
Screenshot 2023-11-15 at 5 09 07 PM
Screenshot 2023-11-15 at 5 08 21 PM

@InnaAtanasova InnaAtanasova modified the milestones: Sprint 126, Sprint 127 Nov 28, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 127, Sprint 128 Dec 12, 2023
@InnaAtanasova
Copy link
Contributor

will be fixed as part of the v1 Card ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev requested changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@mikerodonnell89 mikerodonnell89

Labels
None yet
Projects
None yet
Milestone
Sprint 128
Development

Successfully merging this pull request may close these issues.
3 participants
@mikerodonnell89 @InnaAtanasova @droshev