Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): input and select disabled placeholder #4932

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Oct 27, 2023

Related Issue

relates #4912

Description

  • Visual core states that placeholder should not be visible for any input when it's state is readonly or disabled. Same logic should be applied to a select component;
  • Updated doc examples to resemble such visual states

Screenshots

NOTE: If you've made any style changes, please provide appropriate screenshots (before and after) to help reviewers.

To see examples of which screenshots to include, go to Screenshot Examples.

@N1XUS N1XUS added the Bug Something isn't working label Oct 27, 2023
@N1XUS N1XUS added this to the Sprint 124 milestone Oct 27, 2023
@N1XUS N1XUS requested a review from a team October 27, 2023 12:37
@N1XUS N1XUS self-assigned this Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 2129e7b
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/653bb6d9e68434000870222b
😎 Deploy Preview https://deploy-preview-4932--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@N1XUS N1XUS changed the title fix(styles): input and select disabled placeholder [ci visual] fix(styles): input and select disabled placeholder Oct 27, 2023
@N1XUS N1XUS force-pushed the fix/input-select-disabled-placeholder branch from 004b2c1 to 2129e7b Compare October 27, 2023 13:10
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 124, Sprint 125 Oct 27, 2023
@droshev droshev merged commit 9a4fe47 into main Oct 27, 2023
8 checks passed
@droshev droshev deleted the fix/input-select-disabled-placeholder branch October 27, 2023 18:22
@N1XUS N1XUS mentioned this pull request Oct 30, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants