[feat] Button 컴포넌트 구현 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
beom84
approved these changes
Jan 14, 2025
app/src/main/java/org/android/bbangzip/presentation/type/BbangZipButtonType.kt
Show resolved
Hide resolved
l2zh
reviewed
Jan 14, 2025
app/src/main/java/org/android/bbangzip/presentation/component/button/BbangZipButton.kt
Outdated
Show resolved
Hide resolved
HAJIEUN02
reviewed
Jan 15, 2025
app/src/main/java/org/android/bbangzip/presentation/component/button/BbangZipButton.kt
Show resolved
Hide resolved
| vertical = bbangZipButtonSize.verticalPadding, | ||
| ), | ||
| leadingIcon = { | ||
| if (leadingIcon != null) { |
There was a problem hiding this comment.
p5 Base를 하나 만들어두고, SolidButton Outlined Button 이런 식으로 구성하면 안 들어오면 렌더링 자체가 되지 않으니 leadingIcon이나 trailingIcon이 null인 경우를 처리해줄 필요가 업서요! 이런 식으로 분리하는 방법도 있음을 알아주셔라
app/src/main/java/org/android/bbangzip/presentation/type/BbangZipButtonType.kt
Show resolved
Hide resolved
# Conflicts: # app/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
default.mp4
Uncompleted Tasks 😅
To Reviewers 📢
일단 구조에대해서 리뷰를 좀 받고 다시 해야할 것 같습니다.
혼자 고민을 해봤는데 너무 오래걸렸고 확장성 측면에서 하나도 고려되지 않은 느낌이라 도움을 받고 싶습니다.