Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Button 컴포넌트 구현 #19
[feat] Button 컴포넌트 구현 #19
Changes from 5 commits
b6027cd
ec0dfa4
530d1e7
ddd3bec
f52ed0a
79b394d
958f734
dd13654
9b70c29
6b9245c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5
Base를 하나 만들어두고, SolidButton Outlined Button 이런 식으로 구성하면 안 들어오면 렌더링 자체가 되지 않으니 leadingIcon이나 trailingIcon이 null인 경우를 처리해줄 필요가 업서요! 이런 식으로 분리하는 방법도 있음을 알아주셔라There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
죄송합니다 모르겠습니다 ㅠㅠㅠ