-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mise: Add Version 2025.1.6 #6374
Conversation
/verify |
All changes look good. Wait for review from human collaborators. mise
|
1 similar comment
All changes look good. Wait for review from human collaborators. mise
|
I am trying to do the right thing with the PR title, but the documentation is contradicting.
|
If we want mise to be purged if {
"post_uninstall": [
"if ($purge) {",
" $Directories = [string[]](",
" ('{0}\\mise' -f $env:LOCALAPPDATA),",
" ('{0}\\Temp\\mise' -f $env:LOCALAPPDATA)",
" )",
" $Directories.ForEach{",
" if (Test-Path -Path $_ -PathType 'Container') {",
" $null = Remove-Item -Path $_ -Recurse -Force",
" }",
" }",
"}"
]
} |
I was about to submit a PR; thanks @FilipDeVos! I suggest two things:
|
I noticed that we need to add $env:LOCALAPPDATA\mise\shims to $env:PATH I'll research a bit what the best way of doing this is. |
Scratch this ideaMaybe "post_install" to add it with PowerShell, and "post_uninstall" to remove it? In user context. Something like this (untested): [System.Environment]::SetEnvironmentVariable(
'Path',
('{0};{1}\mise\shims' -f [System.Environment]::GetEnvironmentVariable('Path','User'), $env:LOCALAPPDATA),
'User'
) Edit: Scratch the above, seems Scoop has |
env_add_path only supports folders under the installation folder I think. |
I think this commit does the trick. |
/verify |
Your changes do not pass checks. mise-en-place
|
/verify |
All changes look good. Wait for review from human collaborators. mise-en-place
|
/verify |
All changes look good. Wait for review from human collaborators. mise
|
/verify |
Your changes do not pass checks. mise
|
/verify |
All changes look good. Wait for review from human collaborators. mise
|
anything I can do to help with this? we've managed to get into winget and chocolatey, I'm sure scoop users would love to have mise too! |
Hello, I just reviewed and approved it. @jdx Since you commented here, may I ask if it's good to support customizing the mise home directory via env var (sth like |
I'm not sure I understand what "relocate and persist" would be for, no other package manager for mise does anything like that I don't think |
For Scoop, portable mode is preferred when it's available, currently the data ( Nevermind, I searched the mise codebase and found envs |
Okay this is the diff, and if anyone wants to contribute they could open a new PR with it. diff --git a/bucket/mise.json b/bucket/mise.json
index 531d459f7..5a9c32a66 100644
--- a/bucket/mise.json
+++ b/bucket/mise.json
@@ -15,25 +15,11 @@
},
"extract_dir": "mise",
"bin": "bin/mise.exe",
- "installer": {
- "script": "Add-Path -Path \"$env:LOCALAPPDATA\\mise\\shims\" -Global:$global"
+ "env_set": {
+ "MISE_DATA_DIR": "$dir\\mise"
},
- "uninstaller": {
- "script": "Remove-Path -Path \"$env:LOCALAPPDATA\\mise\\shims\" -Global:$global"
- },
- "post_uninstall": [
- "if ($purge) {",
- " $Directories = [string[]](",
- " ('{0}\\mise' -f $env:LOCALAPPDATA),",
- " ('{0}\\Temp\\mise' -f $env:LOCALAPPDATA)",
- " )",
- " $Directories.ForEach{",
- " if (Test-Path -Path $_ -PathType 'Container') {",
- " $null = Remove-Item -Path $_ -Recurse -Force",
- " }",
- " }",
- "}"
- ],
+ "env_add_path": "mise\\shims",
+ "persist": "mise",
"checkver": {
"github": "https://github.com/jdx/mise"
}, |
…nal env vars Included manifest changes suggested by @chawyehsu in PR ScoopInstaller#6374 which sets the internal mise configurable env var MISE_DATA_DIR to a directory that scoop persists
the changes @chawyehsu mentioned seem ideal, made a PR with the changes at #6453 |
This pull request adds the manifest to install the "mise-en-place" tool from https://github.com/jdx/mise/
Closes #6329
<manifest-name[@version]|chore>: <general summary of the pull request>