-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mise: manifest updated to more portable config #6453
Conversation
…nal env vars Included manifest changes suggested by @chawyehsu in PR ScoopInstaller#6374 which sets the internal mise configurable env var MISE_DATA_DIR to a directory that scoop persists
All changes look good. Wait for review from human collaborators. mise
|
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Chawye Hsu <[email protected]>
Co-authored-by: Chawye Hsu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@chawyehsu is there a reason you didn't merge this after approving it? |
I just forgot to |
With this change the config is lost on every update. I think the issue is that it's using |
I was wrong, because |
Yea good point @eg-bernardo really wish I hadn't forgotten to include that before the manifest went live in the It may be best to submit a quick patch that just prompts new user installs with a warning message about manually migrating any previous configs/data. |
#6484 adds warning message for now |
Included manifest changes suggested by @chawyehsu in PR comment which sets the internal mise configurable env var MISE_DATA_DIR to a directory that scoop persists
Relates to #6374
MISE_DATA_DIR
to a directory inside scoop and persist itMISE_GLOBAL_CONFIG_FILE
to file inside app install dir and persist it