Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Make code compatible with LSTCore structure #395

Merged
merged 5 commits into from
May 2, 2024
Merged

Conversation

ariostas
Copy link
Member

This PR makes the code compatible with the LSTCore structure, while still allowing it to be used as an external package like before. The changes consist of modifying the way the TrackLooper directory is found, and the include path to some headers.

SDL/EndcapGeometry.h Outdated Show resolved Hide resolved
SDL/LST.cc Outdated Show resolved Hide resolved
@slava77
Copy link
Contributor

slava77 commented Apr 30, 2024

/run standalone
/run cmssw

Copy link

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg    144.9    230.2     88.7     76.3     81.0    308.2    103.0    129.1    197.1    814.8    2173.3    1720.2+/- 503.0    1163.6   explicit_cache[s=4] (master)
   avg    127.5    234.3     89.1     79.1     80.8    278.5     94.6    118.6    194.7    718.4    2015.5    1609.5+/- 563.3    1129.2   explicit_cache[s=4] (this PR)

Copy link

There was a problem while building and running with CMSSW. The logs can be found here.

@slava77
Copy link
Contributor

slava77 commented Apr 30, 2024

There was a problem while building and running with CMSSW. The logs can be found here.

the errors are from attempt to #include "RecoTracker/LSTCore/interface/alpaka/Constants.h" and such.

should we keep LST_STANDALONE in the current CMSSW (need a PR to SegmentLinking/cmssw) ? I suppose we are not ready yet to just merge SegmentLinking/cmssw#19 together with this one.

@ariostas
Copy link
Member Author

should we keep LST_STANDALONE in the current CMSSW (need a PR to SegmentLinking/cmssw) ?

Yeah, I forgot that in SegmentLinking/cmssw#19 I had made some other slight modifications to the LST package. For now let's just define LST_STANDALONE for the CMSSW compilation while we get ready to switch to LSTCore.

@ariostas
Copy link
Member Author

ariostas commented May 1, 2024

/run cmssw 22

Copy link

github-actions bot commented May 1, 2024

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@slava77
Copy link
Contributor

slava77 commented May 2, 2024

/run standalone
/run cmssw

Copy link

github-actions bot commented May 2, 2024

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     43.7    322.5    121.6     70.8     93.4    496.1    128.5    157.8     98.9      2.4    1535.8     995.9+/- 266.0     419.0   explicit_cache[s=4] (master)
   avg     44.0    324.2    121.7     70.2     93.6    552.1    129.5    157.4    103.4      1.6    1597.7    1001.6+/- 263.2     436.5   explicit_cache[s=4] (this PR)

Copy link

github-actions bot commented May 2, 2024

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@slava77 slava77 merged commit fb75df2 into master May 2, 2024
3 checks passed
@ariostas ariostas deleted the LSTCore_compatibility branch May 8, 2024 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants