Fix LSTCore compatibility #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slava77
reviewed
May 1, 2024
| @@ -3,6 +3,7 @@ | |||
| <use name="lst_headers"/> | |||
| <use name="DataFormats/TrackerRecHit2D"/> | |||
| <use name="HeterogeneousCore/AlpakaInterface"/> | |||
| <flags CXXFLAGS="-DLST_STANDALONE"/> | |||
There was a problem hiding this comment.
now that it's explicitly here, I'm thinking if LST_EXTERNAL is a more appropriate name to avoid confusion in the purpose.
Since either EXTERNAL or STANDALONE are technically to indicate a negative of being in CMSSW, perhaps even better is to use smth like LST_IS_CMSSW_PACKAGE
There was a problem hiding this comment.
Yeah, I think something like LST_IS_CMSSW_PACKAGE makes sense. I'll close this PR and make the required changes to the other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to SegmentLinking/TrackLooper#395. In that other PR I made some changes so that the master branch is compatible with LSTCore. However, since the LST package uses some of the headers, we need to set
LST_STANDALONEwhen using it as an external so that headers are included properly.