Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LSTCore compatibility #22

Closed
wants to merge 1 commit into from
Closed

Fix LSTCore compatibility #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RecoTracker/LST/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<use name="lst_headers"/>
<use name="DataFormats/TrackerRecHit2D"/>
<use name="HeterogeneousCore/AlpakaInterface"/>
<flags CXXFLAGS="-DLST_STANDALONE"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that it's explicitly here, I'm thinking if LST_EXTERNAL is a more appropriate name to avoid confusion in the purpose.
Since either EXTERNAL or STANDALONE are technically to indicate a negative of being in CMSSW, perhaps even better is to use smth like LST_IS_CMSSW_PACKAGE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think something like LST_IS_CMSSW_PACKAGE makes sense. I'll close this PR and make the required changes to the other PR.

<flags ALPAKA_BACKENDS="cuda serial"/>
<export>
<lib name="1"/>
Expand Down
2 changes: 2 additions & 0 deletions RecoTracker/LST/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
<use name="HeterogeneousCore/AlpakaInterface"/>
<use name="RecoTracker/LST"/>
<use name="RecoTracker/Record"/>
<flags CXXFLAGS="-DLST_STANDALONE"/>
<flags ALPAKA_BACKENDS="serial"/>
<flags EDM_PLUGIN="1"/>
</library>
Expand All @@ -48,6 +49,7 @@
<use name="HeterogeneousCore/AlpakaInterface"/>
<use name="RecoTracker/LST"/>
<use name="RecoTracker/Record"/>
<flags CXXFLAGS="-DLST_STANDALONE"/>
<flags ALPAKA_BACKENDS="cuda"/>
<flags EDM_PLUGIN="1"/>
</library>