Issue 882 - add support for MW 1.40, fix 4.2.0 overrule SMW dev-master #884
Conversation
- add dev-master to require SMW version
- remove MW 1.35 - add MW 1.40
- set experimental to false for MW 1.40
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
=========================================
Coverage ? 45.50%
Complexity ? 2319
=========================================
Files ? 80
Lines ? 9041
Branches ? 0
=========================================
Hits ? 4114
Misses ? 4927
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good. As soon as SMW 5 is available, we can remove dev-master in CI matrix. The skipped tests will be handled in separate issues (created already?). @paladox please have a look at this PR and let us know if you think it's ready to merge.
|
@gesinn-it-gea yes, the issue is opened. I will take a look what could be the problem regarding that issue. |
| @@ -60,6 +60,9 @@ | |||
| { | |||
| "type": "special", | |||
| "about": "#0 `format=bibtex` empty (bibtex-01-0.bib)", | |||
| "skip-on": { | |||
There was a problem hiding this comment.
Do you have the error for this?
There was a problem hiding this comment.
You mean what is the error for specific test or does this skip-on produce an error?
There was a problem hiding this comment.
I will update the issue, and put the errors so the errors can be visiable here as well.
This looks good to me. It's ok to merge. I left a note as curious on what the error is. |
| @@ -46,7 +46,7 @@ | |||
| "require": { | |||
| "php": ">=7.3", | |||
| "composer/installers": ">=1.0.1", | |||
| "mediawiki/semantic-media-wiki": "~3.0|~4.0|~5.0", | |||
| "mediawiki/semantic-media-wiki": "~3.0|~4.0|~5.0|dev-master", | |||
There was a problem hiding this comment.
Revert:
There was a problem hiding this comment.
@JeroenDeDauw are you sure this is not "valid"? It's "discouraged", because dev-master is a moving target. I think this came in during the massive rework on both sides, SMW and SRF to see, if it's working with the latest changes in dev-master
Partial revert of * #884 Packagist sent me a notification that composer.json is no longer valid.
This PR is related to the issue #882.
This PR contains:
dev-mastertorequiresectionci.ymlThis PR also covers the issues #876 and #880.