EBP-479: no data in cache reply #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…retrieve from the cache.
|
Please mark whether you used Copilot to assist coding in this PR
|
sdewilde
reviewed
Feb 11, 2025
oodigie
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
I see there is a test case failure in Github actions but that failure is unrelated to the changes in this PR. It is caused by a test case with a race condition that is being addressed by bug EPB-401.
I give my approval only after all the remaining comments by @sdewilde have been responded to.
sdewilde
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test to verify API behaviour when there is no data to retrieve from the cache.