Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBP-479: no data in cache reply #95

Merged
merged 3 commits into from
Feb 13, 2025
Merged

EBP-479: no data in cache reply #95

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba87d42
EBP-479: Added test to verify API behaviour when there is no data to …
TrentDaniel Feb 11, 2025
b8855c0
EBP-479: Added parametrization and documentation for test in response…
TrentDaniel Feb 12, 2025
7309a25
Merge branch 'SOL-62456' into EBP-479
TrentDaniel Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions test/cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,31 @@ var _ = Describe("Cache Strategy", func() {
deferredOperation()
}
})
DescribeTable("cache reply contains no data", func(topic_template string) {
topic := fmt.Sprintf(topic_template, testcontext.Cache().Vpn)
cacheRequestID := message.CacheRequestID(1)
cacheName := "UnitTest"
cacheRequestConfig := helpers.GetValidAsAvailableCacheRequestConfig(cacheName, topic)
sdewilde marked this conversation as resolved.
Show resolved Hide resolved
receivedMsgChan := make(chan message.InboundMessage, 3)
sdewilde marked this conversation as resolved.
Show resolved Hide resolved
err := receiver.ReceiveAsync(func(msg message.InboundMessage) {
receivedMsgChan <- msg
})
Expect(err).To(BeNil())
channel, err := receiver.RequestCachedAsync(cacheRequestConfig, cacheRequestID)
Expect(err).To(BeNil())
Expect(channel).ToNot(BeNil())
var cacheResponse solace.CacheResponse
Eventually(channel, "5s").Should(Receive(&cacheResponse))
Expect(cacheResponse).ToNot(BeNil())
/* EBP-25: Assert cache reponse ID matches cache request ID. */
/* EBP-26: Assert CacheRequestOutcome is NoData. */
/* EBP-28: Assert err is nil. */
Consistently(receivedMsgChan).ShouldNot(Receive())
},
Entry("with topic 1", "MaxMsgs3/%s/notcached"),
Entry("with topic 2", "Max*sgs3/%s/data1"),
Entry("with topic 3", "MaxMsgs3/%s/nodata"),
)
It("a direct receiver should get an error when trying to send an invalid cache request", func() {
/* NOTE: This test also asserts that the receiver can terminate after a failed attempt to send a cache
* request.
Expand Down
Loading