Save extension class info. #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
h-mayorquin
reviewed
Mar 15, 2024
| @@ -476,3 +477,24 @@ def normal_pdf(x, mu: float = 0.0, sigma: float = 1.0): | |||
| """ | |||
|
|
|||
| return 1 / (sigma * np.sqrt(2 * np.pi)) * np.exp(-((x - mu) ** 2) / (2 * sigma**2)) | |||
|
|
|||
|
|
|||
| def get_class_info(a_class): | |||
There was a problem hiding this comment.
I strongly suggest against something as vague as get_class_info for the name of a function. If I remember well, the point of storing these attributes is to store information about how to instantiate the class. From that perspective I think that something like:
get_importing_provenance- `get_class_location_within_package"
retrieve_class_path
or a combination of them.
I like retrieve_importing_provenance because I think it describes well what it does and it also does not add more suggestions to the get methods that are more used for user relevant information (e.g. get_traces).
There was a problem hiding this comment.
Totally agree.
THanks you for the feedback. lets go for retrieve_importing_provenance
Co-authored-by: Heberto Mayorquin <[email protected]>
for more information, see https://pre-commit.ci
alejoe91
reviewed
Mar 20, 2024
alejoe91
reviewed
Mar 20, 2024
alejoe91
reviewed
Mar 20, 2024
oups. Co-authored-by: Alessio Buccino <[email protected]>
h-mayorquin
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.