-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save extension class info. #2585
Merged
alejoe91
merged 9 commits into
SpikeInterface:main
from
samuelgarcia:analyzer_module_info
Mar 29, 2024
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a6c4767
Save extension class info.
samuelgarcia eb42b3e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d23c1c3
Merci Ramon for feedback
samuelgarcia d0d7df5
Update src/spikeinterface/core/core_tools.py
samuelgarcia 2f7190b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0ceb68d
Apply suggestions from code review
samuelgarcia d1598b1
oups
samuelgarcia 82c4ebb
oups
samuelgarcia f92545b
Merge branch 'main' into analyzer_module_info
h-mayorquin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly suggest against something as vague as
get_class_info
for the name of a function. If I remember well, the point of storing these attributes is to store information about how to instantiate the class. From that perspective I think that something like:get_importing_provenance
retrieve_class_path
or a combination of them.
I like
retrieve_importing_provenance
because I think it describes well what it does and it also does not add more suggestions to the get methods that are more used for user relevant information (e.g. get_traces).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree.
THanks you for the feedback. lets go for retrieve_importing_provenance