-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup dx7 when dx oscillator selected #3004
Merged
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seangoodvibes
approved these changes
Dec 3, 2024
While I agree with the UI change, this does unfortunately not include the steps to actually setup the synth for dx7:
I think we could do this before Together with #2694 we can then completely remove the "custom 1 plus synth" hack. |
bfredl
added a commit
to bfredl/DelugeFirmware
that referenced
this pull request
Dec 3, 2024
bfredl
added a commit
to bfredl/DelugeFirmware
that referenced
this pull request
Dec 3, 2024
bfredl
added a commit
to bfredl/DelugeFirmware
that referenced
this pull request
Dec 3, 2024
follow up to SynthstromAudible#3004 - only setup dx7 on source1. - the ENV1 release should be set to 50 to let the DX7:s internal envelopes release phase play out (yes, we still do voice culling properly when the dx7 envelopes end) - The VEL-> master volume patch cable should not be used as dx7 handles velocity per operator and this additional global patch cable will throw off loaded patches which are properly velocity calibrated internally.
bfredl
added a commit
to bfredl/DelugeFirmware
that referenced
this pull request
Dec 3, 2024
follow up to SynthstromAudible#3004 This restriction was intentional as the UI code (like the operator sidebar) assumes only OSC1 is used as a DX7 oscillator. We might want to improve the UI later on, but for now keep the restriction
bfredl
added a commit
to bfredl/DelugeFirmware
that referenced
this pull request
Dec 3, 2024
follow up to SynthstromAudible#3004 This restriction was intentional as the UI code (like the operator sidebar) assumes only OSC1 is used as a DX7 oscillator. We might want to improve the UI later on, but for now keep the restriction
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
follow up to #3004 This restriction was intentional as the UI code (like the operator sidebar) assumes only OSC1 is used as a DX7 oscillator. We might want to improve the UI later on, but for now keep the restriction
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
follow up to #3004 This restriction was intentional as the UI code (like the operator sidebar) assumes only OSC1 is used as a DX7 oscillator. We might want to improve the UI later on, but for now keep the restriction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the need for the custom 1 plus synth shortcut by just setting up the dx7 engine if an oscillator is set to dx7
I think we should cherry pick this since it's tiny and makes the DX7 a lot more usable