[FEAT] 검색 입력 #32
Merged
[FEAT] 검색 입력 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hynseok
requested changes
Jul 25, 2024
| import { Input, InputProps } from "@mantine/core"; | ||
|
|
||
| export function SearchInput({ placeholder, ...props }: InputProps & { placeholder?: string }) { | ||
| return <Input placeholder={placeholder} {...props} />; |
There was a problem hiding this comment.
leftSection에 검색 아이콘을 고정해두는게 좋을 것 같아요. icon 크기도 props에 담아서 조절할 수 있도록 하면 좋을 것 같습니다!
There was a problem hiding this comment.
넵 그렇게 수정했습니다!
iconSize 기본값은 16으로 설정해두었습니다
moony1204
reviewed
Jul 26, 2024
There was a problem hiding this comment.
아이콘을 leftsection으로 한다면 아이콘 hover 상태일 때 커서 모양 바뀌게 하면 좋을 거 같습니다
There was a problem hiding this comment.
mantine에서 가져온 Input 컴포넌트인데 icon이 있는 곳까지 text area로 판정하는 것 같아서 안 되는 것 같습니다ㅠㅜ
moony1204
reviewed
Jul 26, 2024
mantine에서 기본적으로 설정한 배경색을 사용했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작성자: @chunzhi23
Issue: #5
체크 리스트
작업 내역
비고