Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 검색 입력 #32

Merged
merged 3 commits into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이콘을 leftsection으로 한다면 아이콘 hover 상태일 때 커서 모양 바뀌게 하면 좋을 거 같습니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mantine에서 가져온 Input 컴포넌트인데 icon이 있는 곳까지 text area로 판정하는 것 같아서 안 되는 것 같습니다ㅠㅜ

Empty file.
30 changes: 30 additions & 0 deletions src/components/common/SearchInput/SearchInput.story.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import type { Meta, StoryObj } from "@storybook/react";
import { SearchInput } from "./SearchInput";
import { IconSearch } from "@tabler/icons-react";

// More on how to set up stories at: https://storybook.js.org/docs/writing-stories#default-export
const meta = {
title: "SearchInput",
component: SearchInput,
parameters: {
// Optional parameter to center the component in the Canvas. More info: https://storybook.js.org/docs/configure/story-layout
layout: "centered",
},
// This component will have an automatically generated Autodocs entry: https://storybook.js.org/docs/writing-docs/autodocs
tags: ["autodocs"],
// More on argTypes: https://storybook.js.org/docs/api/argtypes
argTypes: {},
// More on Action Args : https://storybook.js.org/docs/essentials/actions#action-args
args: {},
} satisfies Meta<typeof SearchInput>;

export default meta;
type Story = StoryObj<typeof meta>;

// More on writing stories with args: https://storybook.js.org/docs/writing-stories/args
export const Usage: Story = {
args: {
placeholder: "Input here to search...",
leftSection: <IconSearch size={16} />,
},
};
18 changes: 18 additions & 0 deletions src/components/common/SearchInput/SearchInput.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { render, screen } from "@/utils/test-utils";
import { SearchInput } from "./SearchInput";
import "@testing-library/jest-dom";
import { IconSearch } from "@tabler/icons-react";

describe("SearchInput component", () => {
it("renders correctly with the given placeholder", () => {
const props = {
placeholder: "Input here to search...",
leftSection: <IconSearch size={16} />,
};

render(<SearchInput {...props} />);
// More on screen queries: https://testing-library.com/docs/queries/about
// More on jest expect Api: https://jestjs.io/docs/expect
expect(screen.getByRole("region", { name: "SearchInput" })).toBeInTheDocument();
});
});
5 changes: 5 additions & 0 deletions src/components/common/SearchInput/SearchInput.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { Input, InputProps } from "@mantine/core";

export function SearchInput({ placeholder, ...props }: InputProps & { placeholder?: string }) {
return <Input placeholder={placeholder} {...props} />;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftSection에 검색 아이콘을 고정해두는게 좋을 것 같아요. icon 크기도 props에 담아서 조절할 수 있도록 하면 좋을 것 같습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 그렇게 수정했습니다!
iconSize 기본값은 16으로 설정해두었습니다

}
1 change: 1 addition & 0 deletions src/components/common/SearchInput/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { SearchInput } from "./SearchInput";
Loading