Refactor SAML to use PySAML2 #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dezhidki
force-pushed
the
refactor-saml
branch
2 times, most recently
from
bf38841 to
e169471
Compare
sijualle
previously approved these changes
Nov 8, 2022
OneLogin's implementation is deprecated and not actively maintained at the moment (SAML-Toolkits/python3-saml#320)
dezhidki
force-pushed
the
refactor-saml
branch
from
9318cff to
4c7906f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3233
Refaktoroi SAML-kirjaamista käyttämään PySAML2-kirjastoa python3-saml:n sijaan (katso #3233). Muutos mahdollistaa mm. lxml-kirjaston sekä Pythonin päivittämistä, koska python3-saml:ssa nämä ovat lukittu alas.
Tämän PRn myötä tulevat muutokset:
config.py, katso PySAML2:n speksitTestaus onnistuu https://timdevs02.it.jyu.fi/ käyttämällä Hakan testitunnusta ja -salasanaa (End-user teppo, password testaaja)