Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if there's a way to simplify joint_normalization #50

Open
github-actions bot opened this issue Dec 12, 2024 · 0 comments
Open

Investigate if there's a way to simplify joint_normalization #50

github-actions bot opened this issue Dec 12, 2024 · 0 comments
Labels
enhancement New feature or request qol Quality-of-life changes

Comments

@github-actions
Copy link

since the system expects a [-1, 1] range, we normalize the joint positions to their limits; it is

redundant since we'll undo the normalization later in the controller, so it might warrant a change

newton-isaac-sim/newton.py

Lines 316 to 318 in abf04d6

# TODO: Investigate if there's a way to simplify joint_normalization
# since the system expects a [-1, 1] range, we normalize the joint positions to their limits; it is
# redundant since we'll undo the normalization later in the controller, so it might warrant a change

            # index 7 is the joint position (angle in degrees)
            joint_positions = joint_data[:, 7]

            # TODO: Investigate if there's a way to simplify joint_normalization
            #   since the system expects a [-1, 1] range, we normalize the joint positions to their limits; it is
            #   redundant since we'll undo the normalization later in the controller, so it might warrant a change
            joint_actions = newton_agent.joints_controller.normalize_joint_positions(
                torch.from_numpy(joint_positions)
            )

            # we wrap it in an array to make it 2D (it's a vectorized env)
            env.step(np.array([joint_actions], dtype=np.float32))

        exit(1)
@AugustDG AugustDG added the enhancement New feature or request label Dec 22, 2024
@AugustDG AugustDG added this to the Complete Initial Prototype milestone Dec 22, 2024
@AugustDG AugustDG added the qol Quality-of-life changes label Dec 22, 2024
@AugustDG AugustDG moved this to Backlog in The Newton Capstone Dec 23, 2024
@AugustDG AugustDG removed their assignment Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qol Quality-of-life changes
Projects
Status: Backlog
Development

No branches or pull requests

1 participant