-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tilt max and min angle constraints #13
Merged
TillFleisch
merged 17 commits into
TillFleisch:main
from
bsell93:add-tilt-max-and-min-angle-constraints
Jun 10, 2024
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
aa3ce41
Attempt to add a max tilt angle configuration option/control
bsell93 f1a0447
Make angle negative to flip the value like we do when we are storing it
bsell93 e636410
Try to figure out why max is opposite, setting max of "1" shows every…
bsell93 252656f
Remove negative sign from both angles
bsell93 42f0f8a
Re-add negative sign to angle to hopefully match desired functionality
bsell93 e5a513d
Add a min tilt angle control
bsell93 90c79bb
Add missing min_angle_number_ variable
bsell93 e19d35d
Set min value correctly to -60 deg
bsell93 ab3c7c6
Format documents with clang and black formatters. Add max/min tilt an…
bsell93 5377bd2
Add min/max tilt angle to readme and full example yaml
bsell93 d1da308
Increase default angle restriction
TillFleisch d9a8db4
Add fixed angle config to full test
TillFleisch 96b98cd
Fix fixed-tilt-angle configuration
TillFleisch 9f6baec
Add tracking margin for angle restriction
TillFleisch 87970f0
Restrict min/max angle to not exceed each other
TillFleisch a938ac0
Consolidate min/max angle and distance number components
TillFleisch ad14d0e
Fix typo
TillFleisch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
angle margin missing