-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import transactions from Safe builder #147
feat: import transactions from Safe builder #147
Conversation
Signed-off-by: david <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
will defer reviewing this until changes from lee's suggestions |
…e-transactions-into-snapshot-osnap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error.value = undefined; | ||
} | ||
|
||
// TODO: allow multiple files at once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to allow multiple files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are only allowing them to drop 1 file at a time. but they can drop many, one after the other.
throw new Error('Less than 32 bytes'); | ||
} | ||
|
||
if (!isBytesLike(value)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this check should be done last. i think it should either be in this order, too short, too long, isBytesLIke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. remember dont merge this, please pr to snapshot!
Fixes #UMA-2431
motivation
We want users to be able to use the transaction builder in the safe app, export it, and then import it into the oSnap plugin.
How to test
Test files
This file works ✅
test-file-VALID.json
This file is corrupted ❌ (should display an error message)
test-file-INVALID.json
screenshots: