Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center sections of incident detail view #1159

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

podliashanyk
Copy link
Contributor

Closes #1153. Solution as shown at the flexbox-workshop with the team.

@podliashanyk podliashanyk added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Jan 22, 2025
@podliashanyk podliashanyk requested a review from a team January 22, 2025 15:40
@podliashanyk podliashanyk self-assigned this Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

Test results

   10 files  1 060 suites   37m 56s ⏱️
  536 tests   535 ✅  1 💤 0 ❌
5 360 runs  5 350 ✅ 10 💤 0 ❌

Results for commit ffba88c.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (7564dae) to head (ffba88c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   78.48%   78.48%           
=======================================
  Files         141      141           
  Lines        5442     5442           
=======================================
  Hits         4271     4271           
  Misses       1171     1171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only complaint is the title of this PR, it is not clear what sections you're talking about

Maybe something like "Center sections of incident detail view"

Base automatically changed from stable-col-width-in-detailed-view to master January 24, 2025 09:54
@podliashanyk podliashanyk merged commit 166f542 into master Jan 24, 2025
17 checks passed
@podliashanyk podliashanyk deleted the spacing-between-cols-in-incident-details branch January 24, 2025 10:34
@podliashanyk podliashanyk changed the title Move sections to center Center sections of incident detail view Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add spacing between the edges of screen and the outermost columns in the detailed view
4 participants