Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/os-classifiers-for-build #260

Merged
merged 16 commits into from
Jan 13, 2025

Conversation

sighphyre
Copy link
Member

Adds Maven classifiers to the build system so that maven automatically picks up the correct os/arch at build time and installs the correct version of Yggdrasil that contains that platform's binary

@sighphyre sighphyre changed the base branch from main to feat/yggdrasil-feature-enabled January 9, 2025 07:29
@@ -10,7 +10,7 @@
<version.junit5>5.10.3</version.junit5>
<version.okhttp>4.12.0</version.okhttp>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<version.unleash.specification>5.1.9</version.unleash.specification>
<version.unleash.specification>5.1.7</version.unleash.specification>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolled this back because Windows needs a patch to handle unicode

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's test

@sighphyre sighphyre merged commit 17bf5a8 into feat/yggdrasil-feature-enabled Jan 13, 2025
9 checks passed
@sighphyre sighphyre deleted the chore/classifiers branch January 13, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants