Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/os-classifiers-for-build #260

Merged
merged 16 commits into from
Jan 13, 2025
+18 −5
Merged

chore/os-classifiers-for-build #260

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
eaab146
chore: fan out github build to include windows and macos
sighphyre Jan 9, 2025
1c2386d
wip: temporarily disable java 8 since that doesn't work with a mac ru…
sighphyre Jan 9, 2025
bf7783b
chore: quick and dirty manual classifier for mac/win/linux
sighphyre Jan 9, 2025
6d8eda7
wip: disable mac/windows
sighphyre Jan 9, 2025
058d3f2
wip: lower case linux in classifier
sighphyre Jan 9, 2025
06d54be
wip: dumb test to see if arch classifier works
sighphyre Jan 9, 2025
c0d4ef4
chore: patch os+arch classifiers
sighphyre Jan 9, 2025
28f1ee1
chore: enabled windows
sighphyre Jan 9, 2025
315fe28
chore: try x86_64 classifier for Windows
sighphyre Jan 9, 2025
d947a2c
chore: bumb yggdrasil
sighphyre Jan 9, 2025
fa3f51d
chore: reenable mac
sighphyre Jan 9, 2025
e089693
chore: bump yggdrasil
sighphyre Jan 9, 2025
7633c7f
chore: bump yggdrasil
sighphyre Jan 9, 2025
d822a48
chore: rollback client spec
sighphyre Jan 9, 2025
997f178
chore: rollback client spec some more
sighphyre Jan 9, 2025
464b4b5
chore: reenable java 8 for linux
sighphyre Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/pull_requests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}-latest
strategy:
matrix:
version: [ 8, 11, 17 ]
version: [11, 17]
os: ["ubuntu", "windows", "macos"]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
13 changes: 10 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<version.junit5>5.10.3</version.junit5>
<version.okhttp>4.12.0</version.okhttp>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<version.unleash.specification>5.1.9</version.unleash.specification>
<version.unleash.specification>5.1.7</version.unleash.specification>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolled this back because Windows needs a patch to handle unicode

<arguments />
<version.jackson>2.17.2</version.jackson>
<version.logback>1.3.14</version.logback>
Expand Down Expand Up @@ -59,8 +59,8 @@
<dependency>
<groupId>io.getunleash</groupId>
<artifactId>yggdrasil-engine</artifactId>
<version>0.1.0-alpha.9</version>
<classifier>x86_64-linux</classifier>
<version>0.1.0-alpha.12</version>
<classifier>${os.detected.classifier}</classifier>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId>
Expand Down Expand Up @@ -162,6 +162,13 @@
</dependencies>

<build>
<extensions>
<extension>
<groupId>kr.motd.maven</groupId>
<artifactId>os-maven-plugin</artifactId>
<version>1.7.0</version>
</extension>
</extensions>
<resources>
<resource>
<directory>src/main/resources</directory>
Expand Down
Loading