chore: update yggdrasil to handle latest spec #261
Conversation
sighphyre
force-pushed
the
chore/get-ygg-version-from-ygg
branch
from
580a66b to
cbaa590
Compare
sighphyre
force-pushed
the
chore/get-ygg-version-from-ygg
branch
from
cbaa590 to
8d7e5ab
Compare
sighphyre
force-pushed
the
chore/get-ygg-version-from-ygg
branch
from
b5db17a to
1889e0b
Compare
sighphyre
force-pushed
the
chore/get-ygg-version-from-ygg
branch
from
1889e0b to
5641bf9
Compare
sighphyre
changed the title
| @@ -310,6 +310,7 @@ public void asynchronous_fetch_on_initialisation_fails_silently_and_retries() | |||
| .build(); | |||
|
|
|||
| Unleash unleash = new DefaultUnleash(config); | |||
| Thread.sleep(1); | |||
There was a problem hiding this comment.
cries in Windows So this is the failing test that sent me down the rabbit hole of the client spec tests (which aren't yet fixed). It looks like there's a very subtle difference in the thread scheduler between Windows and Linux. Linux is more precise, which means that the fetch has always completed before the verify runs on the next line. On Windows, this never completes without this sleep
There was a problem hiding this comment.
Yes, we can't wait on DefaultUnleash constructor, but tbh, I don't like it does fetchFeatures as part of constructing the object... I think fetch features should be part of some initialize() method and then maybe you'd be able to wait on it... but sleeping is fine, people need to sleep :)
There was a problem hiding this comment.
Agreed, I'd like it to change too and what you propose is what I'd like to do too, Constructors should construct, not spawn threads.
Small steps though, this is legacy behaviour that's being surfaced because we're doing Windows tests now. Can fix next series of PRs
| @@ -310,6 +310,7 @@ public void asynchronous_fetch_on_initialisation_fails_silently_and_retries() | |||
| .build(); | |||
|
|
|||
| Unleash unleash = new DefaultUnleash(config); | |||
| Thread.sleep(1); | |||
There was a problem hiding this comment.
Yes, we can't wait on DefaultUnleash constructor, but tbh, I don't like it does fetchFeatures as part of constructing the object... I think fetch features should be part of some initialize() method and then maybe you'd be able to wait on it... but sleeping is fine, people need to sleep :)
Bumps Yggdrasil to expose the core version and handle UTF-8 characters
"Fixes" a timing issue on Windows in the tests. How did we not notice that before? Well we've never run these tests on a Windows runner