Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: [downloader] DownloadTargetごとにディレクトリを切るようにする #944

Merged
merged 2 commits into from
Jan 27, 2025
Merged

feat!: [downloader] DownloadTargetごとにディレクトリを切るようにする #944

merged 2 commits into from
Jan 27, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jan 25, 2025

内容

多分これからユーザーはDownloadTargetについて強く意識することになるので、それに沿ってディレクトリが作られるのがわかりやすくなるかなと思った次第です。

関連 Issue

その他

ドキュメント部分は別PRに切り出した方がよいかも

@qryxip qryxip requested a review from Hiroshiba January 25, 2025 17:08
@qryxip
Copy link
Member Author

qryxip commented Jan 25, 2025

ドキュメント部分は別PRに切り出した方がよいかも

#945

@qryxip qryxip force-pushed the feat-downloader-mkdir-for-c-api-and-additional-libraries branch from 6bfe018 to 0c832b3 Compare January 25, 2025 17:20
@qryxip qryxip changed the title feat!: [downloader] c-apiとadditional-librariesのディレクトリを掘る feat!: [downloader] c-api, additional-libraries, dictのディレクトリを掘る Jan 25, 2025
@qryxip qryxip changed the title feat!: [downloader] c-api, additional-libraries, dictのディレクトリを掘る feat!: [downloader] DownloadTargetごとにディレクトリを切るようにする Jan 25, 2025
Hiroshiba
Hiroshiba reviewed Jan 26, 2025
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ディレクトリを分けることによって、動かなくなるあるいは手順が複雑になるexampleがあるかどうかが気になります！
デフォルトの引数名とかを変更して全て対応できるなら、ディレクトリを切った方がよさそう！

@Hiroshiba Hiroshiba mentioned this pull request Jan 26, 2025
Merged
@qryxip qryxip requested a review from Hiroshiba January 27, 2025 14:56
@qryxip
Copy link
Member Author

qryxip commented Jan 27, 2025

デフォルトの引数名とかを変更して全て対応できるなら

一応このPRに全部入れきれているかなーとは思います。

@qryxip qryxip force-pushed the feat-downloader-mkdir-for-c-api-and-additional-libraries branch from 1fa4206 to 578a1b3 Compare January 27, 2025 14:58
@Hiroshiba
Copy link
Member

なるほどです！
ディレクトリ構造の問題でexampleがどうしてもサクッと動かせなかったら再考できればと･･･！

Hiroshiba
Hiroshiba approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

@qryxip qryxip merged commit 3ab4a6c into VOICEVOX:main Jan 27, 2025
35 checks passed
@qryxip qryxip deleted the feat-downloader-mkdir-for-c-api-and-additional-libraries branch January 27, 2025 16:56
@qryxip qryxip mentioned this pull request Jan 28, 2025
Merged
qryxip added a commit that referenced this pull request Feb 4, 2025
@qryxip
build!: DLLとCヘッダをlib/とinclude/に入れる (#954)
0325003 
#942, #944 の続き。

一般的な慣習に従い、C APIのリリース内容物をこうする。

```
├── include
│   └── voicevox_core.h
├── lib
│   ├── voicevox_core.dll
│   └── voicevox_core.lib
├── LICENSE
├── README.txt
└── VERSION
```
qryxip added a commit to qryxip/voicevox_core that referenced this pull request Feb 5, 2025
@qryxip
fix: [example] [Python] fix up VOICEVOX#944: run-asyncio.pyも更新
9291522
qryxip added a commit that referenced this pull request Feb 6, 2025
@qryxip
fix: [example] [Python] fix up #944: run-asyncio.pyも更新 (#969)
e76856b 
変え忘れていたため。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba