Feat/add singing list edit view #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junginyu
requested review from
Anti9uA,
terry-koo and
Eunbi-Cho
as code owners
Anti9uA
approved these changes
Sep 29, 2022
| SongListCellView(songEditButtonTap: $songEditButtonTap, song: $0) | ||
| Divider() | ||
| .background(Color.grayScale6) | ||
| .frame(width: 350) | ||
| } | ||
| .padding(.top, 10) | ||
| AddSongButtonView() | ||
| // TODO: - 이후 업데이트에서 새 노래 추가가 아닌 기존 노래 추가로 기능 변경 | ||
| // AddSongButtonView() |
There was a problem hiding this comment.
노래 추가하는 버튼을 나중에 기존 노래 추가로 변경할 예정이라 일단은 주석으로 남겨둘게요!!
| @@ -16,17 +16,21 @@ extension View { | |||
| /// - Parameter isEditing: 텍스트 필드 편집 여부 확인 | |||
| /// - Parameter isFull: 텍스트 필드 공백 여부 확인 | |||
| /// - Returns: 텍스트 필드 뷰 | |||
| func underlineTextField(isEditing : Bool, isFull: Bool) -> some View { | |||
| func underlineTextField(isEditing : Bool, isFull: Bool, inset: CGFloat, active: Bool = true) -> some View { | |||
There was a problem hiding this comment.
이거 리스트 이름 편집하는 곳에서 언더라인 쓰고 싶은데 글자 크기 커지니까 라인이랑 텍스트랑 너무 붙어있어서 inset이라는 파라미터 추가했어!
active는 리스트에서 언더라인이 편집시에만 나타나야되서 추가한 파라미터야
주석으로 파라미터 설명 추가할게!!
Comment on lines
15
to
16
| @Binding var listEditButtonTap: Bool | ||
| @Binding var songEditButtonTap: Bool |
There was a problem hiding this comment.
이거 지금봤는데 네이밍을 Tap대신에 탭이 된거니깐 Tapped는 어때?
Eunbi-Cho
approved these changes
Sep 29, 2022
…O/Semo into feat/AddSingingListEditView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업사항
추가해야될 사항
이슈 번호
#89