-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add singing list edit view #90
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
77a53a8
[feat] #89 싱잉리스트 디테일 뷰 편집 버튼 활성화 UI 구현
junginyu cfab590
[feat] #89 디테일뷰 편집 UI 구현
junginyu c3a7a2e
[feat] #89 리스트 편집 중 X 버튼 터치 시 발생하는 알림 기능 구현
junginyu b2445c1
Merge branch 'develop' into feat/AddSingingListEditView
junginyu eabd852
[refactor] #89 리스트 편집 뷰 코드 리펙토링 및 변수 네이밍 변경, 함수 파라미터 설명 추가
junginyu f4daa3e
Merge branch 'feat/AddSingingListEditView' of https://github.com/Za-D…
junginyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,9 @@ import SwiftUI | |
|
||
struct SingingListDetailCellView: View { | ||
@Binding var songEditButtonTap: Bool | ||
|
||
var singingList: SingingList | ||
|
||
// MARK: - BODY | ||
var body: some View { | ||
VStack { | ||
|
@@ -29,14 +31,14 @@ struct SingingListDetailCellView: View { | |
.background(Color.grayScale6) | ||
.frame(width: 350) | ||
ForEach(singingList.songArray) { | ||
// TODO: coreData에서 가져온 데이터 넣어주기 | ||
SongListCellView(songEditButtonTap: $songEditButtonTap, song: $0) | ||
Divider() | ||
.background(Color.grayScale6) | ||
.frame(width: 350) | ||
} | ||
.padding(.top, 10) | ||
AddSongButtonView() | ||
// TODO: - 이후 업데이트에서 새 노래 추가가 아닌 기존 노래 추가로 기능 변경 | ||
// AddSongButtonView() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 요거 지워주세용 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 노래 추가하는 버튼을 나중에 기존 노래 추가로 변경할 예정이라 일단은 주석으로 남겨둘게요!! |
||
Spacer() | ||
|
||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 왜 바꾼거야??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 리스트 이름 편집하는 곳에서 언더라인 쓰고 싶은데 글자 크기 커지니까 라인이랑 텍스트랑 너무 붙어있어서 inset이라는 파라미터 추가했어!
active는 리스트에서 언더라인이 편집시에만 나타나야되서 추가한 파라미터야
주석으로 파라미터 설명 추가할게!!