Interaction - Add "pass grenade" interaction

[Timi007]

When merged this pull request will:

• Add "pass grenade" interaction that passes the currently selected grenade

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[johnb432]

When selecting the category, it will either use the last grenade that was passed or the next available one in the inventory.

In my personal opinion, that particular aspect of the PR is not intuitive (magazine passing doesn't have that, so why should grenade passing have it? also no documentation), not helpful (it only saves you the final mouse movement, so it save you pretty little; it's unlikely you'd be passing numerous grenades this way, you'd probably put it in a backpack or the ground) and therefore not useful.

I'd like to hear more from other members of the ACE team though, before you undertake any changes related to that.

[Timi007]

In my personal opinion, that particular aspect of the PR is not intuitive (magazine passing doesn't have that, so why should grenade passing have it? also no documentation), not helpful (it only saves you the final mouse movement, so it save you pretty little; it's unlikely you'd be passing numerous grenades this way, you'd probably put it in a backpack or the ground) and therefore not useful.

Do I understand you correctly that you don't want to have this split into lethal and non-lethal grenades? Should all grenades be listed under "Pass grenade" directly?

Edit:
When passing a magazine, you don't select a specific type. My thought process was that I wanted something similar for grenades but also let the user decide specific types if needed. Sometimes you just want any available lethal grenade passed to you.

As for saving mouse movement and no documentation, the same can be said for the ACE tagging system. You can spray the last used tag by just selecting the top tagging action. This is, as far as I know, also not documented in the wiki.

If needed, I can document this feature in the wiki.

[Drofseh]

When selecting the category, it will either use the last grenade that was passed or the next available one in the inventory.

In my personal opinion, that particular aspect of the PR is not intuitive (magazine passing doesn't have that, so why should grenade passing have it? also no documentation), not helpful (it only saves you the final mouse movement, so it save you pretty little; it's unlikely you'd be passing numerous grenades this way, you'd probably put it in a backpack or the ground) and therefore not useful.

I'd like to hear more from other members of the ACE team though, before you undertake any changes related to that.

I kinda feel like it's too busy with a node for every grenade type carried and that a single pass grenade node that just passes your currently selected grenade would be fine.

[johnb432]

When passing a magazine, you don't select a specific type

Yea, you're right, forgot about that despite having the code under my eyes.

If needed, I can document this feature in the wiki.

Regardless of what will be done in the end, some documentation should be provided.

I kinda feel like it's too busy with a node for every grenade type carried and that a single pass grenade node that just passes your currently selected grenade would be fine.

I agree with it being too busy, especially if you use the radial menu, but I do see the appeal of being able to pass any grenade.

[Timi007]

So do all agree to have only one "pass current grenade" action node and to pass the currently selected grenade?

[Timi007]

Ready for review