-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-165992 Fix Chart Font Family #3685
Conversation
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
@@ -23,7 +23,7 @@ export default (deviceSize) => { | |||
const axisColor = '#767676'; | |||
const options = { | |||
textStyle: { | |||
fontFamily: 'Adobe Clean', | |||
fontFamily: '"Adobe Clean", adobe-clean, "Trebuchet MS", sans-serif', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chart library will add a font family if you don't set any so inheriting from body won't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meganthecoder - using inherit
should do the trick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the failing NALA tests you could try to clear the cached assets with something like:
CURL -si -X POST https://admin.hlx.page/code/robert-bogos/milo/mwpw-142622-project-pep/*
Reminder to set the |
Resolves: MWPW-165992
Test URLs: