chore(ui): bump oauth4webapi major version
#3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3039 +/- ##
=======================================
Coverage 51.09% 51.09%
=======================================
Files 283 283
Lines 25392 25402 +10
=======================================
+ Hits 12973 12979 +6
- Misses 11720 11724 +4
Partials 699 699 ☔ View full report in Codecov by Sentry. |
krancour
approved these changes
Dec 3, 2024
Marvin9
commented
Dec 3, 2024
Marvin9
commented
Dec 4, 2024
| .discoveryRequest(issuerUrl) | ||
| .then((response) => oauth.processDiscoveryResponse(issuerUrl, response)) | ||
| discoveryRequest(issuerUrl, { | ||
| [allowInsecureRequests]: shouldAllowHttpRequest() |
There was a problem hiding this comment.
@krancour FYI this will block auth if IDP is not configured with https. I want to make sure there is absolutely no requirement of http request to IDP except it is local development environment.
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Dec 20, 2024
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Jan 16, 2025
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This could potentially be breaking change if API server does not have SSL and Dex is being used. HTTP requests will not be supported to IDPs
Read all breaking changes here - https://github.com/panva/oauth4webapi/releases/tag/v3.0.0
Old dependabot PR #3025