Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: manual backport of refactored retries (#3060) #3068

Merged
merged 1 commit into from
Dec 5, 2024

manual backport of refactored retries (#3060)

043d3c0
Select commit
Loading
Failed to load commit list.
Merged

chore: manual backport of refactored retries (#3060) #3068

manual backport of refactored retries (#3060)
043d3c0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 1s

51.21% (+0.11%) compared to faa838f

View this Pull Request on Codecov

51.21% (+0.11%) compared to faa838f

Details

Codecov Report

Attention: Patch coverage is 76.08696% with 33 lines in your changes missing coverage. Please review.

Project coverage is 51.21%. Comparing base (faa838f) to head (043d3c0).

Files with missing lines Patch % Lines
internal/controller/promotions/promotions.go 0.00% 20 Missing ⚠️
internal/directives/simple_engine_promote.go 92.55% 6 Missing and 1 partial ⚠️
internal/directives/argocd_updater.go 0.00% 4 Missing ⚠️
api/v1alpha1/promotion_types.go 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.1    #3068      +/-   ##
===============================================
+ Coverage        51.09%   51.21%   +0.11%     
===============================================
  Files              283      283              
  Lines            25406    25450      +44     
===============================================
+ Hits             12981    13033      +52     
+ Misses           11726    11720       -6     
+ Partials           699      697       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov